Skip to content

DOCS: Replace scale with scale_by#1313

Merged
MartinThoma merged 1 commit intopy-pdf:mainfrom
yegorLitvinov:patch-1
Sep 2, 2022
Merged

DOCS: Replace scale with scale_by#1313
MartinThoma merged 1 commit intopy-pdf:mainfrom
yegorLitvinov:patch-1

Conversation

@yegorLitvinov
Copy link
Contributor

scale accepts two params - sx and sy, scale_by - one factor.

`scale` accepts two params - `sx` and `sy`, `scale_by` - one `factor`.
@yegorLitvinov yegorLitvinov changed the title Fix scale in docs DOCS: Replace scale with scale_by Sep 1, 2022

# Scale
page.scale(0.5)
page.scale_by(0.5)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it was confused with Transformation().scale where the one of the arguments is optional.

@MartinThoma MartinThoma merged commit e3fc7f6 into py-pdf:main Sep 2, 2022
@MartinThoma
Copy link
Member

Thank you 🤗

I you want to, I can add you to https://pypdf2.readthedocs.io/en/latest/meta/CONTRIBUTORS.html :-)

MartinThoma added a commit that referenced this pull request Sep 4, 2022
Version 2.10.5, 2022-09-04
--------------------------

New Features (ENH):
-  Process XRefStm (#1297)
-  Auto-detect RTL for text extraction (#1309)

Bug Fixes (BUG):
-  Avoid scaling cropbox twice (#1314)

Robustness (ROB):
-  Fix offset correction in revised PDF (#1318)
-  Crop data of /U and /O in encryption dictionary to 48 bytes (#1317)
-  MultiLine bfrange in cmap (#1299)
-  Cope with 2 digit codes in bfchar (#1310)
-  Accept '/annn' charset as ASCII code (#1316)
-  Log errors during Float / NumberObject initialization (#1315)
-  Cope with corrupted entries in xref table (#1300)

Documentation (DOC):
-  Migration guide (PyPDF2 1.x \xe2\x9e\x94 2.x) (#1324)
-  Creating a coverage report (#1319)
-  Fix AnnotationBuilder.free_text example (#1311)
-  Fix usage of page.scale by replacing it with page.scale_by (#1313)

Developer Experience (DEV):
-  Only run coverage for PyPDF2

Maintenance (MAINT):
-  PdfReaderProtocol (#1303)
-  Throw PdfReadError if Trailer can't be read (#1298)
-  Remove catching OverflowException (#1302)

Full Changelog: 2.10.4...2.10.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants