Skip to content

pybamm.Simulation.save, filename arg is not documented #3602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinsulzer merged 12 commits into from
Dec 8, 2023
Merged

pybamm.Simulation.save, filename arg is not documented #3602

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7aee06e
Added docstring for print_parameter_info method
AbhishekChaudharii Oct 26, 2023
be87f81
PEP8 adherence for One-line docstring
AbhishekChaudharii Oct 26, 2023
3c59897
Mentioned that arrays can be passed as values for drive cycles.
AbhishekChaudharii Oct 27, 2023
9e82990
reverted changes from 3c59897a3ef85e0753997dbb7cc9d3e1c1814835
AbhishekChaudharii Nov 29, 2023
7c5995f
value can be a 2-column array added in steps.py
AbhishekChaudharii Nov 29, 2023
53efe92
style: pre-commit fixes
pre-commit-ci[bot] Nov 29, 2023
ffd36dd
Merge branch 'pybamm-team:develop' into issue_3392_improve_documentation
AbhishekChaudharii Dec 5, 2023
efba2e0
removed cccv_ode
AbhishekChaudharii Dec 5, 2023
6b6ad0d
style: pre-commit fixes
pre-commit-ci[bot] Dec 5, 2023
0aa0358
removed cccv_ode - fix
AbhishekChaudharii Dec 5, 2023
d5106c7
Added documentation for filename argrument in simulation.py
AbhishekChaudharii Dec 8, 2023
f87ba02
Merge branch 'pybamm-team:develop' into issue_3392_improve_API_docume…
AbhishekChaudharii Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed cccv_ode - fix
  • Loading branch information
@AbhishekChaudharii
AbhishekChaudharii authored Dec 5, 2023
commit 0aa035800ae23b69d0a7aedadb4cc9df5cadc427
3 changes: 1 addition & 2 deletions pybamm/step/steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,7 @@ def current(value, **kwargs):
Parameters
----------
value : float
The current value in A.
Value can be a number, a 2-tuple (for cccv_ode), or a 2-column array (for drive cycles)
The current value in A. It can be a number or a 2-column array (for drive cycles).
**kwargs
Any other keyword arguments are passed to the :class:`pybamm.step._Step`
class.
Expand Down