Release 25.1.0 #4756
Merged
Release 25.1.0 #4756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make SEI single layer only * fix failing tests * remove some further instances of inner & outer SEI * shorten comment * fix failing tests * switch examples to IDAKLU solver for robustness * fix typo with SEI OCP * revert to U_SEI = 0.4 V, except O'Kane2022 where beta_inner = 0 * change U_SEI in example to avoid simulation to break (replicates old parameters) * update CHANGELOG (and sort older entries) * remove duplicated entry from CHANGELOG * Update src/pybamm/models/submodels/interface/sei/sei_growth.py * revert some parameter changes as suggested by Simon * reduce SEI diffusivity to 2 significant digits (used to be 16) * Fix changelog --------- Co-authored-by: Ferran Brosa Planella <[email protected]> Co-authored-by: Eric G. Kratz <[email protected]> Co-authored-by: kratman <[email protected]>
…ed plots in case of 1D variables. (#4529) * Modified plot method to take a list of times . * fixed failing tests * added different colours to different time plots * fixed failing tests * added tests for using list of times * added changelog enrty * made small changes * Update CHANGELOG.md Co-authored-by: Agriya Khetarpal <[email protected]> --------- Co-authored-by: Arjun Verma <[email protected]> Co-authored-by: Eric G. Kratz <[email protected]> Co-authored-by: Agriya Khetarpal <[email protected]>
* Release patches * Add changelog * Update CHANGELOG.md
Sync main and 24.11.1
* Update documentation on Integral operator to give additional details on different coordinate systems (#4595) * use double backslash to avoid \pi being interpreted as an escape sequence Co-authored-by: Agriya Khetarpal <[email protected]> --------- Co-authored-by: Agriya Khetarpal <[email protected]>
* Implementing Kolzenberg2020 model as another sei option * Implementing Kolzenberg2020 model as another sei option * Add .mypy_cache to .gitignore * Tunnelling limited has been added for SEI growth * change model's name * Citation name also changed * Citation name also changed * fix failing test * make SEI single layer only * Some test have been added for the new sei models * Bugs in test fixed, pybamm.sign(j) was not passed in dfn test so changed to logic operation * style: pre-commit fixes * fix failing tests * remove some further instances of inner & outer SEI * shorten comment * fix failing tests * switch examples to IDAKLU solver for robustness * fix typo with SEI OCP * revert to U_SEI = 0.4 V, except O'Kane2022 where beta_inner = 0 * change U_SEI in example to avoid simulation to break (replicates old parameters) * update CHANGELOG (and sort older entries) * remove duplicated entry from CHANGELOG * Update src/pybamm/models/submodels/interface/sei/sei_growth.py * revert some parameter changes as suggested by Simon * reduce SEI diffusivity to 2 significant digits (used to be 16) * capitalize the first letter * Capitalizing first letter of the parameters' names * Deleted the file * Update .gitignore Co-authored-by: Eric G. Kratz <[email protected]> * Update tests/unit/test_citations.py Co-authored-by: Eric G. Kratz <[email protected]> * Change log changed * Change log changed --------- Co-authored-by: Ferran Brosa Planella <[email protected]> Co-authored-by: Valentin Sulzer <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Eric G. Kratz <[email protected]>
* docs: update all_contributors.md [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Eric G. Kratz <[email protected]>
* chore: update pre-commit hooks updates: - [github.com/astral-sh/ruff-pre-commit: v0.7.4 → v0.8.0](astral-sh/ruff-pre-commit@v0.7.4...v0.8.0) * style: pre-commit fixes --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Bumps the actions group with 2 updates: [codecov/codecov-action](https://github.com/codecov/codecov-action) and [github/codeql-action](https://github.com/github/codeql-action). Updates `codecov/codecov-action` from 5.0.2 to 5.0.7 - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v5.0.2...v5.0.7) Updates `github/codeql-action` from 3.27.4 to 3.27.5 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@ea9e4e3...f09c1c0) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Revert "Modifies `QuickPlot.plot` to take a list of times and show superimposed plots in case of 1D variables. (#4529)" This reverts commit b50d4a9. * style: pre-commit fixes * Fix changelog with PR number --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sync with release v24.11.2
…dratic (#4614) * separate boundary grad and val, make grad default quadratic * fix script * document and changelog * Update CHANGELOG.md Co-authored-by: Ferran Brosa Planella <[email protected]> * Update CHANGELOG.md --------- Co-authored-by: Alexander Bills <[email protected]> Co-authored-by: Eric G. Kratz <[email protected]> Co-authored-by: Ferran Brosa Planella <[email protected]>
* Removing mentions of run-tests.py Signed-off-by: Pradyot Ranjan <[email protected]> * Usin pytest instead of run-tests mentions Signed-off-by: Pradyot Ranjan <[email protected]> --------- Signed-off-by: Pradyot Ranjan <[email protected]> Co-authored-by: Pradyot Ranjan <[email protected]> Co-authored-by: Eric G. Kratz <[email protected]>
* Remove dev branch install * Temporarily make it build on PRs * Disable building on PRs again
* fix bpx bug when activation energies not provided * update BPX tests * Move function and rename variable --------- Co-authored-by: Eric G. Kratz <[email protected]> Co-authored-by: kratman <[email protected]>
* remove public `set_parameters` * Update CHANGELOG.md
updates: - [github.com/astral-sh/ruff-pre-commit: v0.8.0 → v0.8.1](astral-sh/ruff-pre-commit@v0.8.0...v0.8.1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* bug: make sure symbol always has required mesh attribute * #4637 add to changelog
* fix bpx bug when activation energies not provided * add bpx example * create from bpx obj * style: pre-commit fixes * docs * update BPX tests * Move function and rename variable * Update docs/source/examples/notebooks/parameterization/bpx.ipynb Co-authored-by: Eric G. Kratz <[email protected]> * update pybamm-data and bpx example * style: pre-commit fixes * move initial soc check * fix tests * Update docs/source/examples/notebooks/parameterization/bpx.ipynb Co-authored-by: Eric G. Kratz <[email protected]> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Eric G. Kratz <[email protected]> Co-authored-by: kratman <[email protected]>
Co-authored-by: Robert Timms <[email protected]> Co-authored-by: Saransh Chopra <[email protected]>
Co-authored-by: Eric G. Kratz <[email protected]>
Bumps the actions group with 4 updates: [actions/cache](https://github.com/actions/cache), [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish), [codecov/codecov-action](https://github.com/codecov/codecov-action) and [github/codeql-action](https://github.com/github/codeql-action). Updates `actions/cache` from 4.1.2 to 4.2.0 - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@6849a64...1bd1e32) Updates `pypa/gh-action-pypi-publish` from 1.12.2 to 1.12.3 - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@15c56db...67339c7) Updates `codecov/codecov-action` from 5.0.7 to 5.1.1 - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@015f24e...7f8b4b4) Updates `github/codeql-action` from 3.27.5 to 3.27.6 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@f09c1c0...aa57810) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions - dependency-name: pypa/gh-action-pypi-publish dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Eric G. Kratz <[email protected]>
Co-authored-by: Eric G. Kratz <[email protected]>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.8.1 → v0.8.2](astral-sh/ruff-pre-commit@v0.8.1...v0.8.2) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Eric G. Kratz <[email protected]>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.8.4 → v0.8.6](astral-sh/ruff-pre-commit@v0.8.4...v0.8.6) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Removing IDAKLU, local install of pybammsolvers * Fix test with local install * remove test option, temp change to nox file * Uncomment pybammsolvers dependency * Start removing release and docs references * Minor changes * Fix for casadi import * Cleanup * Second attempt * Fix regex error in fix * Change path method * Fix changelog * Style * Skip some tests * style: pre-commit fixes * Refactor tests * Fixing some warnings * Skip a few more tests * Another skip * More skips * Remove excess skips * Docs update * Add a note to docs * Update required dependencies * Apply suggestions from code review Co-authored-by: Agriya Khetarpal <[email protected]> * Update pyproject.toml Co-authored-by: Agriya Khetarpal <[email protected]> * Update scripts/Dockerfile Co-authored-by: Agriya Khetarpal <[email protected]> * Cleanup from code review * Fix missed message --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Agriya Khetarpal <[email protected]>
Co-authored-by: Eric G. Kratz <[email protected]>
* feat: auto-add state variables to output variables * add changelog * fix lead acid model tests --------- Co-authored-by: Eric G. Kratz <[email protected]>
* Remove an old deprecation warning * Fix outdated syntax * Get rid of unused function
* Started modifying porosity change submodel to work with phases * Porosity now works on composite electrode * Now works for non-composite electrode as well! * style: pre-commit fixes * changelog * style fix * Updated tests * Changed how pref is handled * Added comments to the new if statements * Why did I not think of this before?! * Fixed merge conflict * Removed one last reference to inner and outer * style: pre-commit fixes * Refactored if statement in reaction_driven_porosity.py * changelog * Added comment for Asher * style: pre-commit fixes * Fixed roughness error in reaction_driven_porosity.py * style: pre-commit fixes * Should now work for composite SEI on cracks... * style: pre-commit fixes * Deleted mechanics_option as it's not needed * style: pre-commit fixes --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ferran Brosa Planella <[email protected]> Co-authored-by: Eric G. Kratz <[email protected]>
* geometric param example * add conclusion sentence * add to index: --------- Co-authored-by: Eric G. Kratz <[email protected]>
Bumps the actions group with 5 updates: | Package | From | To | | --- | --- | --- | | [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) | `3.2.0` | `3.3.0` | | [docker/build-push-action](https://github.com/docker/build-push-action) | `6.10.0` | `6.11.0` | | [actions/upload-artifact](https://github.com/actions/upload-artifact) | `4.5.0` | `4.6.0` | | [github/codeql-action](https://github.com/github/codeql-action) | `3.28.0` | `3.28.1` | | [awalsh128/cache-apt-pkgs-action](https://github.com/awalsh128/cache-apt-pkgs-action) | `1.4.2` | `1.4.3` | Updates `docker/setup-qemu-action` from 3.2.0 to 3.3.0 - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](docker/setup-qemu-action@49b3bc8...53851d1) Updates `docker/build-push-action` from 6.10.0 to 6.11.0 - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@48aba3b...b32b51a) Updates `actions/upload-artifact` from 4.5.0 to 4.6.0 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@6f51ac0...65c4c4a) Updates `github/codeql-action` from 3.28.0 to 3.28.1 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@48ab28a...b6a472f) Updates `awalsh128/cache-apt-pkgs-action` from 1.4.2 to 1.4.3 - [Release notes](https://github.com/awalsh128/cache-apt-pkgs-action/releases) - [Commits](awalsh128/cache-apt-pkgs-action@a6c3917...5902b33) --- updated-dependencies: - dependency-name: docker/setup-qemu-action dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions - dependency-name: awalsh128/cache-apt-pkgs-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: update pre-commit hooks updates: - [github.com/astral-sh/ruff-pre-commit: v0.8.6 → v0.9.1](astral-sh/ruff-pre-commit@v0.8.6...v0.9.1) * style: pre-commit fixes --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Remove some missed stuff from the build * style: pre-commit fixes * Simplify deployment * Fix style issue * Review changes * More review comments * nitpick * Fix schema error --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* save computed variables in cycle solutions * Add test for computed variables in cycle solutions * switch assert_array_almost_equal to assert_allclose for test_idaklu file * Trigger RTD build
kratman
requested review from
a team,
DrSOKane,
MarcBerliner,
Saransh-cpp,
TomTranter,
agriyakhetarpal,
arjxn-py,
brosaplanella,
martinjrobins,
rtimms and
valentinsulzer
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4756 +/- ##
==========================================
- Coverage 99.25% 98.66% -0.60%
==========================================
Files 302 303 +1
Lines 22906 23227 +321
==========================================
+ Hits 22735 22916 +181
- Misses 171 311 +140 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brosaplanella
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release branch for v25.1.0
This must be merged instead of squashed.