Skip to content

Conversation

@MarcBerliner
Copy link
Member

@MarcBerliner MarcBerliner commented Nov 24, 2025

Description

Updates the IDAKLUSolver error handling to always throw pybamm.SolverError, and use pybammsolvers' function for generating error messages

Requires pybamm-team/pybammsolvers#75 and pybammsolvers v0.3.3

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@MarcBerliner MarcBerliner marked this pull request as ready for review November 24, 2025 20:36
@MarcBerliner MarcBerliner requested a review from a team as a code owner November 24, 2025 20:36
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.77%. Comparing base (593d2aa) to head (60f1bb7).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5291      +/-   ##
===========================================
- Coverage    98.77%   98.77%   -0.01%     
===========================================
  Files          321      321              
  Lines        27747    27746       -1     
===========================================
- Hits         27407    27406       -1     
  Misses         340      340              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@BradyPlanden BradyPlanden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@MarcBerliner MarcBerliner merged commit df53205 into develop Dec 1, 2025
22 checks passed
@MarcBerliner MarcBerliner deleted the update-solver-errors branch December 1, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants