Skip to content
This repository was archived by the owner on Sep 16, 2024. It is now read-only.

Add espnow #483

Open
wants to merge 23 commits into
base: Dev
Choose a base branch
from
Open

Add espnow #483

Changes from 2 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
f1e4590
Add esp_espnow.c to /mods
Oct 18, 2019
320255e
Compiles espnow
rodgergr Oct 21, 2019
ebe46d8
Add recv_queue_handler
rodgergr Oct 21, 2019
ce2c433
Fix missing link in mpconfigport
Oct 22, 2019
1772e00
First successful compile & build as a Class
Oct 25, 2019
403ec46
Added self_in to methods
Oct 25, 2019
d628cbc
Fix wrong function name error in recv_queue_handler
Mar 8, 2020
e9c7fc4
Save makefile changes
Dec 6, 2020
ef65a7d
Synch to Pycom Dev
Dec 6, 2020
26c0899
Enable -jN Switch
Dec 6, 2020
189735e
Merge branch 'Dev' into espnow_class
Dec 6, 2020
8a816e3
Compiles under 1.20.2.r2
Dec 6, 2020
71f9a74
Make a singleton
rodgergr Dec 12, 2020
38e352b
Modify framebuf to rotate
Jan 17, 2021
f1843e3
Merge branch 'espnow_class' of https://github.com/rodgergr/pycom-micr…
Jan 17, 2021
95b8bd1
Merge branch 'espnow_class' of https://github.com/rodgergr/pycom-micr…
Jan 17, 2021
9402d9f
Revert framebuf
Jan 19, 2021
0e34221
Fix extra #endifs from merge
Jan 19, 2021
912d361
First espnow build success
Jan 22, 2021
94093f3
Merge new ESPNow by glenn20
Feb 8, 2021
c44eb81
Update .gitignore
Feb 8, 2021
6ea03c7
Tidy
Feb 12, 2021
06bff87
Merge branch 'espnow_g20_dev' into espnow_class
Feb 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions esp32/mods/esp_espnow.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,7 @@ STATIC void send_queue_handler(void *arg) {
}
}

STATIC void IRAM_ATTR send_cb(const uint8_t *macaddr, esp_now_send_status_t status)
{
STATIC void IRAM_ATTR send_cb(const uint8_t *macaddr, esp_now_send_status_t status){
if (send_cb_obj != mp_const_none) {
mp_obj_tuple_t *msg = mp_obj_new_tuple(2, NULL);
msg->items[0] = mp_obj_new_bytes(macaddr, ESP_NOW_ETH_ALEN);
Expand All @@ -119,8 +118,7 @@ STATIC void recv_queue_handler(void *arg) {
}
}

STATIC void IRAM_ATTR recv_cb(const uint8_t *macaddr, const uint8_t *data, int len)
{
STATIC void IRAM_ATTR recv_cb(const uint8_t *macaddr, const uint8_t *data, int len) {
if (recv_cb_obj != mp_const_none) {
mp_obj_tuple_t *msg = mp_obj_new_tuple(2, NULL);
msg->items[0] = mp_obj_new_bytes(macaddr, ESP_NOW_ETH_ALEN);
Expand All @@ -129,8 +127,15 @@ STATIC void IRAM_ATTR recv_cb(const uint8_t *macaddr, const uint8_t *data, int l
}
}

// A static pointer to the espnow singleton
STATIC mp_obj_espnow_t *espnow_singleton = NULL;

STATIC mp_obj_t espnow_make_new(const mp_obj_type_t *type, size_t n_args, size_t n_kw, const mp_obj_t *args) {


if (espnow_singleton != NULL) {
return espnow_singleton;
}

mp_obj_espnow_t *self = m_new_obj(mp_obj_espnow_t);
Copy link
Contributor

@geza-pycom geza-pycom Dec 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better if this class would be "singleton", like e.g. CoAp module. As I understand instantiating again this class would result that esp_now is re-initialized which may ruin the already ongoing former instances.

Copy link
Author

@rodgergr rodgergr Dec 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - I agree - perhaps like this??

// A static pointer to the espnow singleton
STATIC mp_obj_espnow_t *espnow_singleton = NULL;

STATIC mp_obj_t espnow_make_new(const mp_obj_type_t *type, size_t n_args, size_t n_kw, const mp_obj_t *args) {

    if (espnow_singleton != NULL) {
        return espnow_singleton;
    } 

    mp_obj_espnow_t *self = m_new_obj(mp_obj_espnow_t);
    self->base.type = type;
    self->number = 0;
    
    ESPNOW_EXCEPTIONS(esp_now_init());  
    ESPNOW_EXCEPTIONS(esp_now_register_recv_cb(recv_cb));
    ESPNOW_EXCEPTIONS(esp_now_register_send_cb(send_cb));

    espnow_singleton = self;

    return MP_OBJ_FROM_PTR(self);
}

l

self->base.type = type;
self->number = 0;
Expand All @@ -139,6 +144,8 @@ STATIC mp_obj_t espnow_make_new(const mp_obj_type_t *type, size_t n_args, size_t
ESPNOW_EXCEPTIONS(esp_now_register_recv_cb(recv_cb));
ESPNOW_EXCEPTIONS(esp_now_register_send_cb(send_cb));

espnow_singleton = self;

return MP_OBJ_FROM_PTR(self);
}

Expand Down