Skip to content

Conversation

chfw
Copy link
Member

@chfw chfw commented Oct 11, 2020

With your PR, here is a check list:

  • Has test cases written?
  • Has all code lines tested?
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • Agree on NEW BSD License for your contribution

@codecov-io
Copy link

codecov-io commented Oct 11, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@c6e6b97). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage          ?   94.23%           
=========================================
  Files             ?        4           
  Lines             ?       52           
  Branches          ?        0           
=========================================
  Hits              ?       49           
  Misses            ?        3           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6e6b97...f352fa1. Read the comment docs.

@chfw chfw merged commit 1d7810f into master Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants