Skip to content

Expose various function in tags publicly #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettcannon merged 61 commits into from
Nov 25, 2019
Merged

Expose various function in tags publicly #231

Changes from 1 commit
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
6bfc7bd
Update to mypy 0.740
brettcannon Nov 9, 2019
d703c2d
Change `Optional[bool]` to `bool` as `None` is not expected
brettcannon Nov 9, 2019
0b9e724
Tweak docsstrings to follow the rest of the file
brettcannon Nov 9, 2019
c722ee0
Make linters happy
brettcannon Nov 9, 2019
8c2c701
Initial implementation of public *_tags() functions
brettcannon Nov 9, 2019
fb58d28
Tweak a test name
brettcannon Nov 9, 2019
4494b1c
Add tests for cpython_tags()
brettcannon Nov 9, 2019
d5f8730
Add tests for pypy_tags()
brettcannon Nov 9, 2019
2495a36
Add tests for generic_tags()
brettcannon Nov 9, 2019
5ccac11
Add tests for compatible_tags()
brettcannon Nov 9, 2019
ff3e41f
Type _generic_interpreter()
brettcannon Nov 9, 2019
9f398c5
Add tests for _platform()
brettcannon Nov 9, 2019
8f54af0
Remove now-dead code
brettcannon Nov 9, 2019
11b9bed
Fix the docstring for _py_interpreter_range()
brettcannon Nov 11, 2019
c8e90d9
Expose mac_platforms() publicly
brettcannon Nov 12, 2019
c091101
Make some type hints on parameters more readable
brettcannon Nov 12, 2019
f50ce38
Fix some whitespace
brettcannon Nov 12, 2019
d0b5b56
Fix up tests for mac_platforms() exposure and making platform functio…
brettcannon Nov 12, 2019
5ef9af0
Document new public functions
brettcannon Nov 12, 2019
c59e596
Fix tests
brettcannon Nov 12, 2019
defe719
Remove an extra blank line
brettcannon Nov 13, 2019
ab7cc6d
Fix spelling mistake
brettcannon Nov 15, 2019
c952f2c
Fix a grammar mistake
brettcannon Nov 15, 2019
1fbecf2
Fix spelling mistake
brettcannon Nov 15, 2019
123c1e6
Fix a grammar mistake
brettcannon Nov 15, 2019
818cd09
Fix spelling mistake
brettcannon Nov 15, 2019
b168c09
Provide an interpreter name example
brettcannon Nov 15, 2019
b31be53
Tweak phrasing on adding "none" ABI automatically
brettcannon Nov 15, 2019
7277b5d
Simplify handling of "none" ABI
brettcannon Nov 15, 2019
36c2d81
Tweak how we say mac_platforms() is special
brettcannon Nov 15, 2019
df7751d
Rename _platforms() to _platform_tags()
brettcannon Nov 15, 2019
6c81919
Clarify what generic_tags() is for
brettcannon Nov 15, 2019
ff384e8
Rename _warn_parameters()
brettcannon Nov 15, 2019
3f57469
Clarify a comment
brettcannon Nov 15, 2019
1559ffc
Use backticks instead of * for parameters
brettcannon Nov 15, 2019
bc53e90
Fix a syntax hiccup
brettcannon Nov 15, 2019
adea500
Use `` over * for parameters
brettcannon Nov 15, 2019
205ee20
Drop PyPy-specific code
brettcannon Nov 15, 2019
ddc23de
Touch up _generic_abi()
brettcannon Nov 15, 2019
8f08a0a
Add tests that we are getting back iterators
brettcannon Nov 15, 2019
559cfa0
Merge branch 'master' into expose-tags
brettcannon Nov 15, 2019
5b65b05
Merge remote-tracking branch 'origin/master' into expose-tags
brettcannon Nov 15, 2019
5677fc1
Make Python 2.7 happy
brettcannon Nov 15, 2019
40b2eb7
Group tests
brettcannon Nov 15, 2019
a6dfaf5
Merge branch 'master' of github.com:pypa/packaging into expose-tags
brettcannon Nov 15, 2019
443a209
Remove unnecessary trailing newline
brettcannon Nov 15, 2019
20311bb
Make tests more granular
brettcannon Nov 15, 2019
bb54afd
Touch up the docs
brettcannon Nov 22, 2019
5329072
Expose interpreter_name()
brettcannon Nov 22, 2019
c51ca15
Be more strict about default ABIs
brettcannon Nov 22, 2019
7dc1b66
Use `None` as the default for python_version
brettcannon Nov 22, 2019
1350516
Fix a typing typo
brettcannon Nov 22, 2019
68ea56f
Accept major-only Python versions
brettcannon Nov 22, 2019
a295307
Fix compatibility_tags() tests to actually run
brettcannon Nov 22, 2019
4331ec5
Add a test case for cpython_tags() w/ default ABI and major-only Pyth…
brettcannon Nov 22, 2019
7603a49
Run Black
brettcannon Nov 22, 2019
e62f138
Add interpreter_version()
brettcannon Nov 24, 2019
61666fa
Deal with a type ambiguity
brettcannon Nov 24, 2019
42814d1
Make Python 2.7 happy
brettcannon Nov 24, 2019
b7e61cd
Run Black
brettcannon Nov 24, 2019
66f13d9
Make Python 2.7 happy some more
brettcannon Nov 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix a typing typo
  • Loading branch information
@brettcannon
brettcannon committed Nov 22, 2019
commit 1350516925d2cf7522b46e5d9740e56896ec9da8
2 changes: 1 addition & 1 deletion packaging/tags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ def _py_interpreter_range(py_version):
def compatible_tags(
python_version=None, # type: Optional[PythonVersion]
interpreter=None, # type: Optional[str]
platforms=None, # type: Optional[str]
platforms=None, # type: Optional[Iterator[str]]
):
# type: (...) -> Iterator[Tag]
"""
Expand Down