Skip to content

32-bit Linux running on 64-bit ARM arch should have platform "linux_armv7l" #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettcannon merged 15 commits into from
Feb 6, 2020
Merged

32-bit Linux running on 64-bit ARM arch should have platform "linux_armv7l" #234

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
30eeb7a
32-bit Linux running on 64-bit ARM arch should have platform "linux_a…
xuhdev Nov 14, 2019
a99d87f
Update tests/test_tags.py
xuhdev Jan 24, 2020
ca81f77
Update tests/test_tags.py
xuhdev Jan 24, 2020
e189007
Merge branch 'master' into arm
xuhdev Jan 27, 2020
22b943a
Formatting using black
xuhdev Jan 28, 2020
7c11eac
Merge branch 'master' into arm
xuhdev Jan 28, 2020
e9a63dd
Correct platform string in the tests
xuhdev Jan 28, 2020
966bf56
Merge branch 'master' into arm
xuhdev Jan 29, 2020
063710c
Update CHANGELOG.rst
xuhdev Jan 29, 2020
96f096c
Update CHANGELOG.rst
xuhdev Feb 1, 2020
931b182
Update CHANGELOG.rst
xuhdev Feb 1, 2020
76fa89c
Update CHANGELOG.rst
xuhdev Feb 1, 2020
fd1533e
Parametrize the tests
xuhdev Feb 2, 2020
8f534e3
Merge branch 'master' into arm
brettcannon Feb 6, 2020
8af0830
Add back in the is_x86() fixture
brettcannon Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests/test_tags.py 
Co-Authored-By: Brett Cannon <[email protected]>
  • Loading branch information
@xuhdev @brettcannon
xuhdev and brettcannon authored Jan 24, 2020
commit ca81f77ca07a230adc3f3d401e55f3f6b15dcf9d
2 changes: 1 addition & 1 deletion tests/test_tags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ def test_linux_platforms_32bit_on_64bit_os_arm(self, is_64bit_os, is_arm, monkey
if platform.system() != "Linux" or not is_64bit_os or not is_arm:
monkeypatch.setattr(distutils.util, "get_platform", lambda: "linux_aarch64")
monkeypatch.setattr(tags, "_is_manylinux_compatible", lambda *args: False)
linux_platform = tags._linux_platforms(is_32bit=True)[-1]
linux_platform = list(tags._linux_platforms(is_32bit=True))[-1]
assert linux_platform == "linux_armv7l"

def test_linux_platforms_manylinux_unsupported(self, monkeypatch):
Expand Down