Skip to content

Conversation

@aixtools
Copy link

@aixtools aixtools commented Dec 9, 2019

Just a test PR to better learn how CI testing is working.

Work in progress - should be safe to ignore.

@brettcannon
Copy link
Member

I'm going to close this as you should be able to run the tests on your own fork as well for any necessary experimentation.

@aixtools aixtools deleted the test-pypy branch December 12, 2019 16:23
@aixtools
Copy link
Author

Brett, I do not have pypy3 on windows, and what this showed, imho, is that master is not passing it's own requirements. The only change made here is a comment added to tags.py, and it failed at the same point as the PR I submitted.

I have neither the skills nor the resources to research and fix Windows issues that have nothing to do with what I am trying to contribute.

I have no explanation for how it passed #243 - but it did not pass here.

I wish I could be more help, but I cannot for this particular matter.

For the record - I do try and run the tests as thoroughly as I can before I push anything. Learning how coverage works was a real challenge.

Happy holidays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants