Skip to content

fix: platform tag for GraalPy #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettcannon merged 3 commits into from
Sep 1, 2023
Merged

fix: platform tag for GraalPy #711

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd47545
fix: platform tag for GraalPy
mayeut Aug 20, 2023
b9759ee
add tests for `_32_BIT_INTERPRETER`
mayeut Aug 26, 2023
51c9497
Tweak comments on parameterized tests
brettcannon Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: platform tag for GraalPy 
When running a 64-bit version of GraalPy (either x86_64 or aarch64), packaging returns the wrong platform tag (either i686 or armv8l).

Fix this by using the same default implementation as found in stdlib platform.architecture https://github.com/python/cpython/blob/4d4393139fae39db26dead33529b6ae0bafbfc58/Lib/platform.py#L713-L716
  • Loading branch information
@mayeut
mayeut committed Aug 20, 2023
commit bd475458016ad2886c57ab5e698435cb18e4e804
3 changes: 2 additions & 1 deletion src/packaging/tags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import logging
import platform
import struct
import subprocess
import sys
import sysconfig
Expand Down Expand Up @@ -37,7 +38,7 @@
}


_32_BIT_INTERPRETER = sys.maxsize <= 2**32
_32_BIT_INTERPRETER = struct.calcsize("P") == 4


class Tag:
Expand Down