Assorted repo-review suggestions #820
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
approved these changes
Aug 5, 2024
henryiii
approved these changes
Aug 5, 2024
Contributor
Author
|
I can add a repo-review pre-commit hook if you're interested: https://pypi.org/project/sp-repo-review/ |
DimitriPapadopoulos
force-pushed
the
repo-review
branch
from
628f30a to
ded8062
Compare
DimitriPapadopoulos
force-pushed
the
repo-review
branch
from
ded8062 to
d83dda2
Compare
DimitriPapadopoulos
force-pushed
the
repo-review
branch
from
d83dda2 to
268f5da
Compare
DimitriPapadopoulos
force-pushed
the
repo-review
branch
from
268f5da to
59b861b
Compare
Must not have show_error_codes. It is now the default.
If --fix is present, --show-fixes must be too.
DimitriPapadopoulos
force-pushed
the
repo-review
branch
from
59b861b to
0747ae4
Compare
Member
|
Looks like we ended up picking these changes up in #902. Gonna go ahead and close this out! Thanks @DimitriPapadopoulos! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://learn.scientific-python.org/development/guides/repo-review/?repo=pypa%2Fpackaging&branch=main