Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
f9366da
Remove setup.py develop code path
sbidoul Mar 8, 2025
cafa715
Remove legacy editable tests
sbidoul May 10, 2025
aed7024
Refactor get_created_direct_url test
sbidoul May 18, 2025
8add656
Rework PipTestResult for detection of modern editables
sbidoul May 18, 2025
50804ff
Update tests that were looking for egg-link files to detect editables
sbidoul May 10, 2025
85bb55a
Test there is no fallback when backend has no PEP 660
sbidoul Sep 27, 2025
3cc9e6b
Update uninstall tests that depend on legacy install methods
sbidoul Sep 27, 2025
4eda5e4
Update pip show test that depends on legacy install method
sbidoul Sep 27, 2025
674df32
Remove non PEP 517 code paths
sbidoul Sep 28, 2025
90fa35d
Remove --use-pep517 option test
sbidoul Sep 28, 2025
0dbd25e
Remove --no-use-pep517 test
sbidoul Sep 28, 2025
05e53ef
Update creation of test package that must fail building
sbidoul Sep 28, 2025
fe02d65
Run unit tests with no build isolation
sbidoul Sep 28, 2025
873a1c5
Remove tests that exercise --global-option
sbidoul Sep 28, 2025
017d5e6
Rework test that needed --global-option to use --config-setting
sbidoul Sep 28, 2025
0e07ba2
Test install pip without build isolation
sbidoul Sep 28, 2025
16b2601
Remove legacy 'setup.py clean' tests
sbidoul Sep 28, 2025
8fec3f0
Add --no-build-isolation to tests
sbidoul Sep 28, 2025
b3871c6
Add news
sbidoul Sep 27, 2025
6feecc2
Fix and expand PEP 660 detection
sbidoul Sep 28, 2025
893ab4b
Remove a few more obsolete pep517 things from the test suite
sbidoul Sep 29, 2025
5a17132
Docs: reflect removal of direct setup.py invocations
sbidoul Oct 18, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove --use-pep517 option test
This option is now always on, so need to test it.
  • Loading branch information
sbidoul committed Oct 21, 2025
commit 90fa35d6462983c1f3804a80be6c2d0f98764d22
58 changes: 0 additions & 58 deletions tests/unit/test_options.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,64 +198,6 @@ def test_cache_dir__PIP_NO_CACHE_DIR_invalid__with_no_cache_dir(
main(["--no-cache-dir", "fake"])


class TestUsePEP517Options:
"""
Test options related to using --use-pep517.
"""

def parse_args(self, args: list[str]) -> Values:
# We use DownloadCommand since that is one of the few Command
# classes with the use_pep517 options.
command = create_command("download")
options, args = command.parse_args(args)

return options

def test_no_option(self) -> None:
"""
Test passing no option.
"""
options = self.parse_args([])
assert options.use_pep517 is None

def test_use_pep517(self) -> None:
"""
Test passing --use-pep517.
"""
options = self.parse_args(["--use-pep517"])
assert options.use_pep517 is True

def test_PIP_USE_PEP517_true(self, monkeypatch: pytest.MonkeyPatch) -> None:
"""
Test setting PIP_USE_PEP517 to "true".
"""
monkeypatch.setenv("PIP_USE_PEP517", "true")
options = self.parse_args([])
# This is an int rather than a boolean because strtobool() in pip's
# configuration code returns an int.
assert options.use_pep517 == 1

def test_PIP_USE_PEP517_false(self, monkeypatch: pytest.MonkeyPatch) -> None:
"""
Test setting PIP_USE_PEP517 to "false".
"""
monkeypatch.setenv("PIP_USE_PEP517", "false")
options = self.parse_args([])
# This is an int rather than a boolean because strtobool() in pip's
# configuration code returns an int.
assert options.use_pep517 == 0

def test_use_pep517_and_PIP_USE_PEP517_false(
self, monkeypatch: pytest.MonkeyPatch
) -> None:
"""
Test passing --use-pep517 and setting PIP_USE_PEP517 to "false".
"""
monkeypatch.setenv("PIP_USE_PEP517", "false")
options = self.parse_args(["--use-pep517"])
assert options.use_pep517 is True


class TestOptionsInterspersed(AddFakeCommandMixin):
def test_general_option_after_subcommand(self) -> None:
# FakeCommand intentionally returns the wrong type.
Expand Down