Skip to content

Don't assume master branch exists when reinstalling editable package from Git #4450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xavfernandez merged 4 commits into from
Sep 29, 2017
Merged

Don't assume master branch exists when reinstalling editable package from Git #4450

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83c5c94
Add failing test
di Apr 17, 2017
eac3146
Don't assume master branch is default
di Apr 17, 2017
58fa40b
Don't expect output to stderr
di Sep 1, 2017
b90acf9
Use the 'short ref' instead of the 'full ref'
di Sep 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't expect output to stderr
  • Loading branch information
@di
di committed Sep 1, 2017
commit 58fa40be81344e5bbfc225d02b6ce11c7d54d0de
2 changes: 0 additions & 2 deletions tests/functional/test_install_vcs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,6 @@ def test_reinstalling_works_with_editible_non_master_branch(script):
'install', '-e',
'%s#egg=version_pkg' %
('git+file://' + version_pkg_path.abspath.replace('\\', '/')),
expect_stderr=True,
)
version = script.run('version_pkg')
assert '0.1' in version.stdout
Expand All @@ -280,7 +279,6 @@ def test_reinstalling_works_with_editible_non_master_branch(script):
'install', '-e',
'%s#egg=version_pkg' %
('git+file://' + version_pkg_path.abspath.replace('\\', '/')),
expect_stderr=True,
)
version = script.run('version_pkg')
assert 'some different version' in version.stdout