Skip to content

Replace open(file, 'r') with open(file) #9591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pradyunsg merged 2 commits into from
Feb 23, 2021
Merged

Replace open(file, 'r') with open(file) #9591

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f13e10c
Replace `open(file, 'r')` with `open(file)`
hexagonrecursion Feb 10, 2021
20688ee
Don't forget to close an open file
hexagonrecursion Feb 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Don't forget to close an open file
  • Loading branch information
@hexagonrecursion
hexagonrecursion committed Feb 10, 2021
commit 20688ee8e8df1229312b0ed1a0b556ed7045c6b0
3 changes: 2 additions & 1 deletion tests/functional/test_install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1321,7 +1321,8 @@ def test_cleanup_after_failed_wheel(script, with_wheel):
# One of the effects of not cleaning up is broken scripts:
script_py = script.bin_path / "script.py"
assert script_py.exists(), script_py
shebang = open(script_py).readline().strip()
with open(script_py) as f:
shebang = f.readline().strip()
assert shebang != '#!python', shebang
# OK, assert that we *said* we were cleaning up:
# /!\ if in need to change this, also change test_pep517_no_legacy_cleanup
Expand Down