Skip to content

Merge distutils at 5229dad46b #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jaraco merged 20 commits into from
Apr 10, 2022
Merged

Merge distutils at 5229dad46b #3258

jaraco merged 20 commits into from
Apr 10, 2022

Conversation

@jaraco
Copy link
Member

@jaraco jaraco commented Apr 10, 2022 •
edited
Loading

  • Fix EXT_SUFFIX for windows py<3.8
  • Fix SO too
  • Move EXT_SUFFIX support to _py39compat, to be removed after support for Python 3.9 is dropped. Fall back to default behavior on Python 3.10. Remove functionality for SO, which has been long deprecated and is untested.
  • 👹 Feed the hobgoblins (delint).
  • Just modify the vars in place.
  • Restore expectation that SO matches EXT_SUFFIX with rationale.
  • Get the version logic correct.
  • Move compatibility concerns out of the function to do the adding.
  • Emit warning after parsing. Fixes The warning in (Loose)Version is emitted before __repr__ works distutils#122.
  • Disable installation of Setuptools in tox instead of GHA. Ref Tests fail when tox/virtualenv installs setuptools 60+ distutils#99.
  • Use cache_tag in default build_platlib dir
  • Skip test_get_makefile_filename on non-CPython
  • Update test_home_installation_scheme for pypy install paths
  • Refactor as simple replace. If a full string substitution proves to be necessary, let's create a mapping.

isuruf and others added 20 commits March 27, 2022 12:09
@isuruf
Fix EXT_SUFFIX for windows py<3.8
c743883
@isuruf
Fix SO too
e3de684
@jaraco
Move EXT_SUFFIX support to _py39compat, to be removed after support f…
74dc536 
…or Python 3.9 is dropped. Fall back to default behavior on Python 3.10. Remove functionality for SO, which has been long deprecated and is untested.
@jaraco
👹 Feed the hobgoblins (delint).
79dc357
@jaraco
Just modify the vars in place.
8f8d655
@jaraco
Restore expectation that SO matches EXT_SUFFIX with rationale.
55da5cb
@jaraco
Get the version logic correct.
8270cfa
@jaraco
Move compatibility concerns out of the function to do the adding.
96629b7
@jaraco
Merge pull request #131 from isuruf/ext_suffix_win_py37
fde3555 
Fix EXT_SUFFIX for windows py<3.8
@jaraco
Emit warning after parsing. Fixes pypa/distutils#122.
f2e73a4
@jaraco
Disable installation of Setuptools in tox instead of GHA. Ref pypa/di…
2a233e5 
…stutils#99.
@mgorny
Use cache_tag in default build_platlib dir
1c23f5e 
Use `sys.implementation.cache_tag` instead of Python version to create
the default directory for `build_platlib`.  This guarantees that
the directories used by CPython and PyPy are distinct.  Prior to
the change, both CPython and PyPy would use e.g. `lib.linux-x86_64-3.9`.
With the change, they are going to use `lib.linux-x86_64-cpython39`
and `lib.linux-x86_64-pypy39` respectively.
@mgorny
Skip test_get_makefile_filename on non-CPython
c76269b 
The Makefile is specific to CPython and does not exist e.g. on PyPy
installs.  Skip the test appropriately.
@mgorny
Update test_home_installation_scheme for pypy install paths
12fd59d
@jaraco
Refactor as simple replace. If a full string substitution proves to b…
9d86bf2 
…e necessary, let's create a mapping.
@jaraco
Merge pull request #135 from mgorny/pypy-home-scheme
a64a054 
Update test_home_installation_scheme for pypy install paths
@jaraco
Merge pull request #133 from mgorny/build_dir-cache_tag
ee180a7 
Use cache_tag in default build_platlib dir
@jaraco
Merge pull request #134 from mgorny/non-cpy-makefile
5229dad 
Skip test_get_makefile_filename on non-CPython
@jaraco
Merge https://github.com/pypa/distutils into feature/distutils-5229da…
f4d3174 
…d46b
@jaraco
Update changelog.
08c89e3
@jaraco jaraco merged commit f8bb416 into main Apr 10, 2022
@jaraco jaraco deleted the feature/distutils-5229dad46b branch April 10, 2022 19:46
@abravalheri abravalheri mentioned this pull request Apr 12, 2022
Closed
@ice-tong ice-tong mentioned this pull request Jan 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The warning in (Loose)Version is emitted before __repr__ works

4 participants

@jaraco @isuruf @mgorny