Skip to content

Replace tqdm with Rich for progress bar #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhrutledge merged 13 commits into from
Mar 11, 2022
+31 −32
Merged

Replace tqdm with Rich for progress bar #877

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ce3d85a
Throttle upload for testing
bhrutledge Feb 20, 2022
52c745d
Add initial rich progress bar
bhrutledge Feb 20, 2022
dfdb9cc
Define progress bar columns
bhrutledge Feb 20, 2022
78074db
Remove throttling code
bhrutledge Feb 20, 2022
ad1259a
Remove tqdm
bhrutledge Feb 20, 2022
530ec12
Rework retries test
bhrutledge Feb 20, 2022
7fed68d
Add custom time column
bhrutledge Feb 22, 2022
baa16c1
Add rich to intersphinx
bhrutledge Feb 22, 2022
4f8c1d4
Revert "Add rich to intersphinx"
bhrutledge Mar 11, 2022
eaa7a63
Revert "Add custom time column"
bhrutledge Mar 11, 2022
6c0d11b
Use single compact time column
bhrutledge Mar 11, 2022
fbe8e11
Merge branch 'main' into 818-rich-progress
bhrutledge Mar 11, 2022
464f525
Add changelog entry
bhrutledge Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove throttling code
  • Loading branch information
@bhrutledge
bhrutledge committed Feb 20, 2022
commit 78074dbb6eaa4919216c04062a55d39d4667f1c5
11 changes: 5 additions & 6 deletions twine/repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,15 +160,14 @@ def _upload(self, package: package_file.PackageFile) -> requests.Response:
rich.progress.TransferSpeedColumn(),
disable=self.disable_progress_bar,
) as progress:
task_id = progress.add_task("Progress:", total=encoder.len)

def update_progress(monitor): # type: ignore
progress.update(task_id, completed=monitor.bytes_read)
import time; time.sleep(0.2) # fmt: skip
task_id = progress.add_task("", total=encoder.len)

monitor = requests_toolbelt.MultipartEncoderMonitor(
encoder,
update_progress,
lambda monitor: progress.update(
task_id,
completed=monitor.bytes_read,
),
)

resp = self.session.post(
Expand Down