Skip to content

Rely on email.message to parse a header. #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhrutledge merged 7 commits into from
Jan 6, 2023
Merged

Rely on email.message to parse a header. #969

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c16ea58
Rely on email.message to parse a header.
jaraco Dec 18, 2022
d38a226
👹 Feed the hobgoblins (delint).
jaraco Dec 18, 2022
93b44dc
🧎‍♀️ Genuflect to the types.
jaraco Dec 18, 2022
6ce2f36
🧎‍♀️ Genuflect to the types.
jaraco Dec 24, 2022
e45f5fa
Indicate private utility method
bhrutledge Jan 3, 2023
4479fd5
Merge branch 'main' into debt/parse-header
bhrutledge Jan 4, 2023
44149b7
Replace comment with docstring
bhrutledge Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Indicate private utility method
  • Loading branch information
@bhrutledge
bhrutledge committed Jan 3, 2023
commit e45f5faa16be66ed36d742e8467d94e728e01cee
4 changes: 2 additions & 2 deletions twine/commands/check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def __str__(self) -> str:


# from Python 3.11 docs
def parse_content_type(value: str) -> Tuple[str, Dict[str, str]]:
def _parse_content_type(value: str) -> Tuple[str, Dict[str, str]]:
Copy link
Contributor

@bhrutledge bhrutledge Jan 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I tweaked this to be aligned with the other utility methods/classes in this module.

msg = email.message.EmailMessage()
msg["content-type"] = value
return msg.get_content_type(), msg["content-type"].params
Expand All @@ -89,7 +89,7 @@ def _check_file(
)
description_content_type = "text/x-rst"

content_type, params = parse_content_type(description_content_type)
content_type, params = _parse_content_type(description_content_type)
renderer = _RENDERERS.get(content_type, _RENDERERS[None])

if description is None or description.rstrip() == "UNKNOWN":
Expand Down