adapt for upcoming changes in PyPy's SOABI tag #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
approved these changes
Aug 25, 2020
Contributor
|
One more thing – could you add a news entry for this? I'm not sure I understand these changes well enough. |
Contributor
Author
|
added a news blurb, feel free to fix it up. It seems too wordy to me. |
Contributor
|
Sorry for not being clear – I was hoping for something more concise for the news item, maybe a one-liner. I can think of something on my own too. |
Contributor
Author
|
redone now that I reviewed what I did and understood it more completely |
Contributor
Author
|
maybe "'Future-proof calculating the ABI tag from PyPy's SOABI tag" ? |
Contributor
|
Thanks! |
Contributor
Author
|
Thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #372. PyPy currently has a SOABI tag like
pypy36-pp73(only the ABI tag) but according to PEP 3149 it should bepypy36-pp73-x86_64-linux-gnu(ABI tag - platform tag). PyPy may change this in an upcoming release.This should be forward compatible, as long as the ABI tag contains a single
-.