Skip to content

Support float values for --cov-fail-under. #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ionelmc merged 4 commits into from
Sep 2, 2019
Merged

Support float values for --cov-fail-under. #311

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc56caa
Support float values for --cov-fail-under.
Jul 26, 2019
c6c53c0
Merge branch 'master' of github.com:pytest-dev/pytest-cov into 260-co…
graingert Aug 29, 2019
5befa8a
try parsing cov-fail-under as int then float
graingert Aug 29, 2019
68e6f4d
test cov-fail-under float pass and fail
graingert Aug 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/pytest_cov/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def pytest_addoption(parser):
group.addoption('--no-cov', action='store_true', default=False,
help='Disable coverage report completely (useful for debuggers). '
'Default: False')
group.addoption('--cov-fail-under', action='store', metavar='MIN', type=int,
group.addoption('--cov-fail-under', action='store', metavar='MIN', type=float,
help='Fail if the total coverage is less than MIN.')
group.addoption('--cov-append', action='store_true', default=False,
help='Do not delete coverage but append to current. '
Expand Down Expand Up @@ -263,20 +263,24 @@ def pytest_terminal_summary(self, terminalreporter):

terminalreporter.write('\n' + self.cov_report.getvalue() + '\n')

if self.options.cov_fail_under is not None and self.options.cov_fail_under > 0:
if self.cov_total < self.options.cov_fail_under:
fail_under = self.options.cov_fail_under
if fail_under is not None and fail_under > 0:
str_fail_under = str(
round(fail_under, 2) if fail_under % 1 else int(fail_under)
)
if self.cov_total < fail_under:
markup = {'red': True, 'bold': True}
message = (
'FAIL Required test coverage of %d%% not '
'FAIL Required test coverage of %s%% not '
'reached. Total coverage: %.2f%%\n'
% (self.options.cov_fail_under, self.cov_total)
% (str_fail_under, self.cov_total)
)
else:
markup = {'green': True}
message = (
'Required test coverage of %d%% '
'Required test coverage of %s%% '
'reached. Total coverage: %.2f%%\n'
% (self.options.cov_fail_under, self.cov_total)
% (str_fail_under, self.cov_total)
)
terminalreporter.write(message, **markup)

Expand Down
14 changes: 14 additions & 0 deletions tests/test_pytest_cov.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,20 @@ def test_cov_min_50(testdir):
])


def test_cov_min_float_value(testdir):
script = testdir.makepyfile(SCRIPT)

result = testdir.runpytest('-v',
'--cov=%s' % script.dirpath(),
'--cov-report=term-missing',
'--cov-fail-under=51.03',
script)
assert result.ret == 0
result.stdout.fnmatch_lines([
'Required test coverage of 51.03% reached. Total coverage: *%'
])


def test_cov_min_no_report(testdir):
script = testdir.makepyfile(SCRIPT)

Expand Down