-
Notifications
You must be signed in to change notification settings - Fork 247
Create new dist option 'loadgroup' #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Create new dist option 'loadgroup'
- Loading branch information
commit 52a395888ffb3e65e015041a7a23b602cc92f145
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| from .loadscope import LoadScopeScheduling | ||
| from py.log import Producer | ||
|
|
||
|
|
||
| class LoadGroupScheduling(LoadScopeScheduling): | ||
| """Implement load scheduling across nodes, but grouping test only has group mark. | ||
| This distributes the tests collected across all nodes so each test is run | ||
baekdohyeop marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| just once. All nodes collect and submit the list of tests and when all | ||
| collections are received it is verified they are identical collections. | ||
| Then the collection gets divided up in work units, grouped by group mark | ||
| (If there is no group mark, it is itself a group.), and those work units | ||
| et submitted to nodes. Whenever a node finishes an item, it calls | ||
| ``.mark_test_complete()`` which will trigger the scheduler to assign more | ||
| work units if the number of pending tests for the node falls below a low-watermark. | ||
| When created, ``numnodes`` defines how many nodes are expected to submit a | ||
| collection. This is used to know when all nodes have finished collection. | ||
| This class behaves very much like LoadScopeScheduling, | ||
| but with a itself or group(by marked) scope. | ||
| """ | ||
|
|
||
| def __init__(self, config, log=None): | ||
| super().__init__(config, log) | ||
| if log is None: | ||
| self.log = Producer("loadgroupsched") | ||
| else: | ||
| self.log = log.loadgroupsched | ||
|
|
||
| def _split_scope(self, nodeid): | ||
| """Determine the scope (grouping) of a nodeid. | ||
| There are usually 3 cases for a nodeid:: | ||
| example/loadsuite/test/test_beta.py::test_beta0 | ||
| example/loadsuite/test/test_delta.py::Delta1::test_delta0 | ||
| example/loadsuite/epsilon/__init__.py::epsilon.epsilon | ||
| #. Function in a test module. | ||
| #. Method of a class in a test module. | ||
| #. Doctest in a function in a package. | ||
| With loadgroup, two cases are added:: | ||
| example/loadsuite/test/test_beta.py::test_beta0 | ||
| example/loadsuite/test/test_delta.py::Delta1::test_delta0 | ||
| example/loadsuite/epsilon/__init__.py::epsilon.epsilon | ||
| example/loadsuite/test/test_gamma.py::test_beta0@gname | ||
| example/loadsuite/test/test_delta.py::Gamma1::test_gamma0@gname | ||
| This function will group tests with the scope determined by splitting | ||
| the first ``@`` from the right. That is, test will be grouped in a | ||
| single work unit when they have same group name. | ||
| In the above example, scopes will be:: | ||
| example/loadsuite/test/test_beta.py::test_beta0 | ||
| example/loadsuite/test/test_delta.py::Delta1::test_delta0 | ||
| example/loadsuite/epsilon/__init__.py::epsilon.epsilon | ||
| gname | ||
| gname | ||
| """ | ||
| if nodeid.rfind("@") > nodeid.rfind("]"): | ||
| # check the index of ']' to avoid the case: parametrize mark value has '@' | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
| return nodeid.split("@")[-1] | ||
| else: | ||
| return nodeid | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.