Skip to content

Added Akhilesh Ramakrishnan to AUTHORS #11153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
The-Compiler merged 2 commits into from
Jul 3, 2023
Merged

Added Akhilesh Ramakrishnan to AUTHORS #11153

The-Compiler merged 2 commits into from
Jul 3, 2023

Conversation

@akhilramkee
Copy link
Contributor

@akhilramkee akhilramkee commented Jul 1, 2023

@akhilramkee
Copy link
Contributor Author

akhilramkee commented Jul 1, 2023

cc @nicoddemus. Thanks!

@The-Compiler
Copy link
Member

The-Compiler commented Jul 2, 2023

Thanks @akhilramkee! While you're at it, could you fix a small typo in changelog/10337.bugfix.rst please?

Fixed but that fake intermediate modules generated by --import-mode=importlib would not include the child modules as attributes of the parent modules.

I don't think that "but" there makes sense.

@akhilramkee
Copy link
Contributor Author

akhilramkee commented Jul 2, 2023

could you fix a small typo in changelog/10337.bugfix.rst please?

Sure!

@The-Compiler The-Compiler merged commit 024e62e into pytest-dev:main Jul 3, 2023
@The-Compiler
Copy link
Member

The-Compiler commented Jul 3, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@The-Compiler The-Compiler The-Compiler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akhilramkee @The-Compiler