Skip to content

docs: Fix wrong statement about sys.modules with importlib import mode #12985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicoddemus merged 1 commit into from
Nov 25, 2024
Merged

docs: Fix wrong statement about sys.modules with importlib import mode #12985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
docs: Fix wrong statement about sys.modules with importlib import mode 
Follow-up to #7870, see #12983.
  • Loading branch information
@The-Compiler
The-Compiler committed Nov 23, 2024
commit 196001da11ba49e428ef6952f5a3406f86410fab
4 changes: 2 additions & 2 deletions doc/en/explanation/goodpractices.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,8 @@ Note that this layout also works in conjunction with the ``src`` layout mentione
to avoid surprises such as a test module getting imported twice.

With ``--import-mode=importlib`` things are less convoluted because
pytest doesn't need to change ``sys.path`` or ``sys.modules``, making things
much less surprising.
pytest doesn't need to change ``sys.path``, making things much less
surprising.


.. _which-import-mode:
Expand Down
Loading