Skip to content

Fix error with --import-mode=importlib and modules containing dataclasses or pickle #7870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicoddemus merged 11 commits into from
Apr 5, 2021
Merged

Fix error with --import-mode=importlib and modules containing dataclasses or pickle #7870

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1aebd9a
Fix errors when using `--import-mode=importlib` with dataclasses or p…
tadeu Oct 7, 2020
f278286
Construct full module names when using importmode=importlib
nicoddemus Dec 19, 2020
4014529
Improve docs
nicoddemus Dec 19, 2020
fe95061
Fix tests after rebase
nicoddemus Dec 19, 2020
2c87a26
Fix linting
nicoddemus Dec 19, 2020
2a44829
Improve tests
nicoddemus Dec 19, 2020
eeb5889
Improve docs
nicoddemus Dec 19, 2020
72d9ef0
Use getattr to avoid #type:ignore
nicoddemus Dec 19, 2020
d67bb82
Inject sub-modules when importing with importlib
nicoddemus Dec 19, 2020
03e78ff
Fix tests
nicoddemus Apr 2, 2021
91661a0
Fix linting
nicoddemus Apr 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use getattr to avoid #type:ignore
  • Loading branch information
@nicoddemus
nicoddemus committed Apr 2, 2021
commit 72d9ef05db231dae98057b235ca70aa4a3b653de
9 changes: 5 additions & 4 deletions testing/test_pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ class Data:
)

module = import_path(fn, mode="importlib", root=tmp_path)
Data: Any = module.Data # type: ignore[attr-defined]
Data: Any = getattr(module, "Data")
data = Data(value="foo")
assert data.value == "foo"
assert data.__module__ == "src.tests.test_dataclass"
Expand All @@ -491,7 +491,8 @@ def round_trip():
)

module = import_path(fn, mode="importlib", root=tmp_path)
action: Any = module.round_trip() # type: ignore[attr-defined]
round_trip = getattr(module, "round_trip")
action = round_trip()
assert action() == 42


Expand Down Expand Up @@ -537,10 +538,10 @@ def round_trip(obj):
return pickle.loads(s)

module = import_path(fn1, mode="importlib", root=tmp_path)
Data1 = module.Data # type: ignore[attr-defined]
Data1 = getattr(module, "Data")

module = import_path(fn2, mode="importlib", root=tmp_path)
Data2 = module.Data # type: ignore[attr-defined]
Data2 = getattr(module, "Data")

assert round_trip(Data1(20)) == Data1(20)
assert round_trip(Data2("hello")) == Data2("hello")
Expand Down