fix: use uint8 instead of int8 for instruction serialization #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have some instructions to update product metadata that have size of more than int8 max (127) and the on-chain program reads them as u8. So we are switching to UInt8 instead.
ali-behjati
added a commit
to pyth-network/pyth-crosschain
that referenced
this pull request
Jun 24, 2024
This change updates @pythnetwork/client package that has a change that allows encoding large upd_product proposals. More info on [the PR](pyth-network/pyth-client-js#79) in the pyth-client-js repo.
ali-behjati
added a commit
to pyth-network/pyth-crosschain
that referenced
this pull request
Jun 24, 2024
This change updates @pythnetwork/client package that has a change that allows encoding large upd_product proposals. More info on [the PR](pyth-network/pyth-client-js#79) in the pyth-client-js repo.
ali-behjati
added a commit
to pyth-network/pyth-crosschain
that referenced
this pull request
Jun 24, 2024
This change updates @pythnetwork/client package that has a change that allows encoding large upd_product proposals. More info on [the PR](pyth-network/pyth-client-js#79) in the pyth-client-js repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some instructions to update product metadata that have size of more than int8 max (127) and the on-chain program reads them as u8. So we are switching to UInt8 instead.