fix add_feed_ids bug #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anihamde
approved these changes
Feb 22, 2024
| self.feed_ids = list(set(self.feed_ids).union(new_feed_ids_set)) | ||
|
|
||
| # update self.pending_feed_ids with only those IDs that are truly new | ||
| self.pending_feed_ids = list(set(self.pending_feed_ids).union(new_feed_ids_set)) |
There was a problem hiding this comment.
i guess this is just making sure no duplicates in pending_feed_ids? I don't think it matters too much bc there's an implicit redundancy check at the rust websocket level, but this is fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is a current duplicate bug with
add_feed_idswhere if you add multiple duplicate ids,pending_feed_idswill result in duplicate ids as explained here #54 (comment)