feat: Use benchmarks API for historical data #3138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
fhqvst
force-pushed
the
fhqvst/ui-276-use-benchmarks-api-for-historical-data
branch
from
a008adb to
a697c35
Compare
cprussin
requested changes
Oct 17, 2025
There was a problem hiding this comment.
The change is overall good! But I think there's a few more things before we ship it:
- I think the
/historical-pricesendpoint is now dead code, can you check and clean it up if so? - @ali-behjati can you tell us how hard it would be to add CI to the benchmarks endpoint? Is it feasible? I really hate losing CI from the historical charts, plus it does seem reasonable that we might want to have CI in the benchmarks apis.
Comment on lines
+188
to
+193
| const data = benchmarkData.t.map((timestamp, i) => ({ | ||
| time: timestamp as UTCTimestamp, | ||
| price: benchmarkData.c[i], // Use close price | ||
| confidence: 0, // No confidence data from benchmarks API | ||
| status: PriceStatus.Trading, | ||
| })); |
There was a problem hiding this comment.
I'd do this using a zod transform
cprussin
reviewed
Oct 17, 2025
| // Transform OHLC data to our format using close prices | ||
| const data = benchmarkData.t.map((timestamp, i) => ({ | ||
| time: timestamp as UTCTimestamp, | ||
| price: benchmarkData.c[i], // Use close price |
There was a problem hiding this comment.
I don't love this -- I think we will need to put more thought in here. If we aren't showing OHLC candles, I think the chart will be misleading. Plus, we should have full resolution (individual points) when zoomed all the way in, so OHLC doesn't really make sense at that resolution. Let's grab some time to chat through this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this PR we now consume historical price data from the Benchmarks API instead of using our own hand-rolled Clickhouse query.
One downside is that we don't have confidence intervals in the Benchmarks API...
Rationale
Our clients' users have complained that they're seeing inconsistent data in insights hub vs. the data on our clients' pages. With this change we now make sure that the data our clients are consuming is the same one we're using on insights hub, meaning there shouldn't be any inconsistencies.
How has this been tested?