feat(pyth-lazer-agent): add HTTP proxy support for WebSocket connections #3142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=80&v=4){kind=small}
Add proxy_url configuration option to support connecting through HTTP/HTTPS proxies. Implements manual HTTP CONNECT handshake with Basic authentication support and TLS upgrade for secure WebSocket connections. - Add proxy_url: Option<Url> to Config struct - Implement connect_through_proxy function with HTTP CONNECT method - Support Basic authentication via proxy URL credentials - Add tokio-native-tls dependency for TLS support - Update README with proxy configuration examples - Bump version from 0.6.1 to 0.7.0 Co-Authored-By: Mike Rolish <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
- Use inline format args for cleaner string formatting - Replace slice indexing with safe .get() method - All clippy checks now pass Co-Authored-By: Mike Rolish <[email protected]>
Co-Authored-By: Mike Rolish <[email protected]>
merolish
reviewed
Oct 17, 2025
| stream | ||
| .write_all(connect_request.as_bytes()) | ||
| .await | ||
| .context("Failed to send CONNECT request to proxy")?; |
There was a problem hiding this comment.
Could you note the proxy url here?
| let n = stream | ||
| .read(&mut response) | ||
| .await | ||
| .context("Failed to read CONNECT response from proxy")?; |
There was a problem hiding this comment.
Could you note the proxy url here?
| ); | ||
| } | ||
|
|
||
| tracing::info!("Successfully connected through proxy"); |
There was a problem hiding this comment.
Could you note the proxy url here?
| .context("Failed to complete WebSocket handshake")?; | ||
|
|
||
| tracing::info!( | ||
| "WebSocket connection established to relayer at {}", |
There was a problem hiding this comment.
Could you note that this is through a proxy and the url?
…ging - Add proxy URL to error messages when sending/reading CONNECT requests - Add proxy URL to success log after proxy connection - Add proxy URL to final WebSocket success log for better traceability Co-Authored-By: Mike Rolish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added HTTP/HTTPS proxy support to pyth-lazer-agent to enable WebSocket connections through corporate proxies. The implementation includes:
http://user:pass@proxy:port)Link to Devin run: https://app.devin.ai/sessions/9950b0a51eae4b2a87edd70073d61223
Requested by: Mike Rolish ([email protected]), @merolish
Rationale
A customer requires proxy support to use pyth-lazer-agent in their corporate environment. The
tokio-tungstenitelibrary doesn't support proxies directly, requiring manual implementation of the HTTP CONNECT protocol (RFC 2817).Changes
proxy_url: Option<Url>configuration fieldconnect_through_proxy()function with HTTP CONNECT handshaketokio-native-tlsdependency for TLS support through proxy tunnelHow has this been tested?
This implementation is untested with an actual proxy server. Key areas requiring careful review:
HTTP CONNECT implementation (lines 27-137 in
relayer_session.rs):TLS upgrade logic (lines 109-125):
Security - Credential logging (lines 80-81, 88-90, 102, 131-135):
http://user:pass@proxy:port) will be logged in plaintextBasic authentication (lines 67-73):
Missing validation: