format_compact_decimal incorrectly works when the pattern has no 0 characters

[jun66j5]

Overview Description

format_compact_decimal incorrectly works when the pattern has no 0 characters. Also, it doesn't handle count="1" rule.

Steps to Reproduce

>>> from babel import numbers
>>> numbers.format_compact_decimal(1000, format_type='long', locale='it')
'mille1'  # should be 'mille'
>>> numbers.format_compact_decimal(1234, format_type='long', locale='it')
'mille1'  # should be '1 mila'
>>> numbers.format_compact_decimal(1000, format_type='long', locale='fr')
'1 millier'  # should be 'mille'
>>> numbers.format_compact_decimal(1234, format_type='long', locale='fr')
'1 millier'  # correct

Additional Information

• https://github.com/unicode-org/cldr/blob/release-41/common/main/it.xml#L5210
• https://github.com/unicode-org/cldr/blob/release-41/common/main/fr.xml#L7743
• Explicit 0 and 1 rules

[DenverCoder1]

With the "mille1" issue, this seems like it is likely more of an issue with NumberPattern / NumberPattern.apply, right?

>>> numbers.format_decimal(1234, format="example")
'example1234'

It probably should not include the number if the format does not have a place for it?

[DenverCoder1]

should be '1 mila'

Are we certain about 1000 returning different pluralization than 1234?

Previously we had said format_compact_decimal(21098765, locale='mk', format_type='long') would return 21 милион instead of 21 милиони because the plural rule for 21 is "one".

This would contradict that and require us to modify that test.

[jun66j5]

Are we certain about 1000 returning different pluralization than 1234?

Yes, I think. See Plural Operand Meanings and Plural Operand Examples.

>>> from babel.core import Locale
>>> it = Locale.parse('it')
>>> it.plural_form.rules['one']
'i in 1 and v in 0'
>>> for n in (1, 1.0, 1.2, Decimal('1'), Decimal('1.0'), Decimal('1.2')):
...   n, it.plural_form(n)
...
(1, 'one')
(1.0, 'one')
(1.2, 'other')
(Decimal('1'), 'one')
(Decimal('1.0'), 'other')
(Decimal('1.2'), 'other')
>>>> 
>>> Decimal('1000') / 1000
Decimal('1')
>>> Decimal('1234') / 1000
Decimal('1.234')
>>> it.plural_form(Decimal('1000') / 1000)
'one'
>>> it.plural_form(Decimal('1234') / 1000)
'other'

Previously we had said format_compact_decimal(21098765, locale='mk', format_type='long') would return 21 милион instead of 21 милиони because the plural rule for 21 is "one".

This would contradict that and require us to modify that test.

Yeah, I misunderstood i and v plural operands. I'll look your pull request #932.