Skip to content

fix(numbers): correctly determine malformed decimals #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akx merged 3 commits into from
Nov 28, 2023
Merged

fix(numbers): correctly determine malformed decimals #1042

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f39f58
fix(numbers): correctly determine malformed decimals
olunusib Nov 11, 2023
b6ec29d
Add some more test cases for decimal parsing
akx Nov 28, 2023
e89a6c9
Clarify remove-trailing-zeros logic a bit
akx Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clarify remove-trailing-zeros logic a bit
  • Loading branch information
@akx
akx committed Nov 28, 2023
commit e89a6c9c2f56c2e1a87330f45d801f8ca1f11cec
6 changes: 4 additions & 2 deletions babel/numbers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1158,8 +1158,10 @@ def _remove_trailing_zeros_after_decimal(string: str, decimal_symbol: str) -> st
integer_part, _, decimal_part = string.partition(decimal_symbol)

if decimal_part:
stripped_part = decimal_part.rstrip("0")
return integer_part + (decimal_symbol + stripped_part if stripped_part else "")
decimal_part = decimal_part.rstrip("0")
if decimal_part:
return integer_part + decimal_symbol + decimal_part
return integer_part

return string

Expand Down