Skip to content

Conversation

@tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Nov 9, 2024

Since python 3.7, dict preserves insertion order. I think we can safely replace OrderedDict with dict.

@codecov
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (313277a) to head (f80a8bc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1149      +/-   ##
==========================================
- Coverage   91.28%   91.27%   -0.01%     
==========================================
  Files          27       27              
  Lines        4623     4619       -4     
==========================================
- Hits         4220     4216       -4     
  Misses        403      403              
Flag Coverage Δ
macos-12-3.10 90.04% <100.00%> (-0.01%) ⬇️
macos-12-3.11 89.97% <100.00%> (-0.01%) ⬇️
macos-12-3.12 90.19% <100.00%> (-0.01%) ⬇️
macos-12-3.13-dev 89.71% <100.00%> (-0.01%) ⬇️
macos-12-3.8 89.96% <100.00%> (-0.01%) ⬇️
macos-12-3.9 89.96% <100.00%> (-0.01%) ⬇️
macos-12-pypy3.10 90.04% <100.00%> (-0.01%) ⬇️
ubuntu-22.04-3.10 90.06% <100.00%> (-0.01%) ⬇️
ubuntu-22.04-3.11 89.99% <100.00%> (-0.01%) ⬇️
ubuntu-22.04-3.12 90.21% <100.00%> (-0.01%) ⬇️
ubuntu-22.04-3.13-dev 89.73% <100.00%> (-0.01%) ⬇️
ubuntu-22.04-3.8 89.99% <100.00%> (-0.01%) ⬇️
ubuntu-22.04-3.9 89.99% <100.00%> (-0.01%) ⬇️
ubuntu-22.04-pypy3.10 90.06% <100.00%> (-0.01%) ⬇️
windows-2022-3.10 90.18% <100.00%> (-0.01%) ⬇️
windows-2022-3.11 90.11% <100.00%> (-0.01%) ⬇️
windows-2022-3.12 90.33% <100.00%> (-0.01%) ⬇️
windows-2022-3.13-dev 89.85% <100.00%> (-0.01%) ⬇️
windows-2022-3.8 90.11% <100.00%> (-0.01%) ⬇️
windows-2022-3.9 90.11% <100.00%> (-0.01%) ⬇️
windows-2022-pypy3.10 90.18% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, absolutely!

@akx akx merged commit 0005c85 into python-babel:master Nov 10, 2024
26 checks passed
@tomasr8 tomasr8 deleted the odict branch November 10, 2024 20:47
@akx akx added this to the Babel 2.17 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants