Skip to content

Improve contributing instructions #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akx merged 4 commits into from
Mar 3, 2023
Merged

Improve contributing instructions #986

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42faff7
Remove test-env makefile target (use tox instead)
akx Mar 3, 2023
5b7a128
makefile: don't import-cldr before tox; it'll clean it
akx Mar 3, 2023
d2c84b7
Move dev dependencies to dev extra
akx Mar 3, 2023
c616775
Improve CONTRIBUTING.md
akx Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove test-env makefile target (use tox instead)
  • Loading branch information
@akx
akx committed Mar 3, 2023
commit 42faff7d3a28a9411532c5b45ed06de2456f15ef
15 changes: 2 additions & 13 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,7 @@
test: import-cldr
python ${PYTHON_TEST_FLAGS} -m pytest ${PYTEST_FLAGS}

test-env:
virtualenv test-env
test-env/bin/pip install pytest
test-env/bin/pip install --editable .

clean-test-env:
rm -rf test-env

standalone-test: import-cldr test-env
test-env/bin/pytest tests ${PYTEST_FLAGS}

clean: clean-cldr clean-pyc clean-test-env
clean: clean-cldr clean-pyc

import-cldr:
python scripts/download_import_cldr.py
Expand All @@ -31,4 +20,4 @@ develop:
tox-test: import-cldr
tox

.PHONY: test develop tox-test clean-pyc clean-cldr import-cldr clean clean-test-env standalone-test
.PHONY: test develop tox-test clean-pyc clean-cldr import-cldr clean standalone-test