Skip to content

fix(completions): add quoting of command names #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neersighted merged 3 commits into from
Sep 6, 2022
Merged

fix(completions): add quoting of command names #247

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c05e913
fix(completions): add quoting of command names
Secrus Sep 3, 2022
ffcf629
Fix windows testing
Secrus Sep 4, 2022
17445b5
Merge branch 'main' into fix/completions
Secrus Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix windows testing
  • Loading branch information
@Secrus
Secrus committed Sep 4, 2022
commit ffcf629fe7fd1385cfe8151ccacc13083e22dae0
4 changes: 4 additions & 0 deletions tests/commands/completion/test_completions_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

import pytest

from cleo._compat import WINDOWS
from cleo.application import Application
from cleo.testers.command_tester import CommandTester
from tests.commands.completion.fixtures.command_with_colons import CommandWithColons
Expand All @@ -31,6 +32,7 @@ def test_invalid_shell() -> None:
tester.execute("pomodoro")


@pytest.mark.skipif(WINDOWS, reason="Only test linux shells")
def test_bash(mocker: MockerFixture) -> None:
mocker.patch(
"cleo.io.inputs.string_input.StringInput.script_name",
Expand All @@ -52,6 +54,7 @@ def test_bash(mocker: MockerFixture) -> None:
assert expected == tester.io.fetch_output().replace("\r\n", "\n")


@pytest.mark.skipif(WINDOWS, reason="Only test linux shells")
def test_zsh(mocker: MockerFixture) -> None:
mocker.patch(
"cleo.io.inputs.string_input.StringInput.script_name",
Expand All @@ -73,6 +76,7 @@ def test_zsh(mocker: MockerFixture) -> None:
assert expected == tester.io.fetch_output().replace("\r\n", "\n")


@pytest.mark.skipif(WINDOWS, reason="Only test linux shells")
def test_fish(mocker: MockerFixture) -> None:
mocker.patch(
"cleo.io.inputs.string_input.StringInput.script_name",
Expand Down