Skip to content

CompletionsCommand - fix fish completions #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MatteoCampinoti94 wants to merge 3 commits into from
Closed

CompletionsCommand - fix fish completions #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90d9df9
CompletionsCommand - fix fish completions
MatteoCampinoti94 Oct 16, 2022
4376dd0
CompletionsCommand - use cmd.name directly for fish completion -a arg…
MatteoCampinoti94 Oct 16, 2022
33c4ea3
tests/completions/fish - update fish.txt with quoted commands in -a a…
MatteoCampinoti94 Oct 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cleo/commands/completions_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ def sanitize(s: str) -> str:
command_name = shell_quote(cmd.name) if " " in cmd.name else cmd.name
cmds.append(
f"complete -c {script_name} -f -n '__fish{function}_no_subcommand' "
f"-a {command_name} -d '{sanitize(cmd.description)}'"
f"-a '{cmd.name}' -d '{sanitize(cmd.description)}'"
)
cmds_opts += [
f"# {command_name}",
Expand Down
8 changes: 4 additions & 4 deletions tests/commands/completion/fixtures/fish.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ complete -c script -n '__fish_my_function_no_subcommand' -l verbose -d 'Increase
complete -c script -n '__fish_my_function_no_subcommand' -l version -d 'Display this application version.'

# commands
complete -c script -f -n '__fish_my_function_no_subcommand' -a command:with:colons -d 'Test.'
complete -c script -f -n '__fish_my_function_no_subcommand' -a hello -d 'Complete me please.'
complete -c script -f -n '__fish_my_function_no_subcommand' -a help -d 'Displays help for a command.'
complete -c script -f -n '__fish_my_function_no_subcommand' -a list -d 'Lists commands.'
complete -c script -f -n '__fish_my_function_no_subcommand' -a 'command:with:colons' -d 'Test.'
complete -c script -f -n '__fish_my_function_no_subcommand' -a 'hello' -d 'Complete me please.'
complete -c script -f -n '__fish_my_function_no_subcommand' -a 'help' -d 'Displays help for a command.'
complete -c script -f -n '__fish_my_function_no_subcommand' -a 'list' -d 'Lists commands.'
complete -c script -f -n '__fish_my_function_no_subcommand' -a 'spaced command' -d 'Command with space in name.'

# command options
Expand Down