Backport fix for mismatching hash check#193
Merged
sdispater merged 2 commits intopython-poetry:1.0from Aug 26, 2021
pietrodn:fix/package-clone-backport
Merged
Backport fix for mismatching hash check#193sdispater merged 2 commits intopython-poetry:1.0from pietrodn:fix/package-clone-backport
sdispater merged 2 commits intopython-poetry:1.0from
pietrodn:fix/package-clone-backport
Conversation
Downstream clients (e.g., poetry) appear to assume that the result of a Package.clone() will be a full-fidelity copy of the original. Use `copy.deepcopy` to clone the object, and ensure that this is the case. Resolves Issue #2422 Co-authored-by: Nicolas Simonds <nisimond@cisco.com>
sdispater
approved these changes
Aug 26, 2021
This was referenced Aug 27, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #159 to poetry-core 1.0 as this is part of an important security fix.
See python-poetry/poetry#3885 and python-poetry/poetry#2422
I think that this fix exposes a preexisting bug in Poetry where
poetry installfails with the following:I think that there is an underlying bug where an object that should be a
Pathis actually aLink, and that is exposed by the fact that thePackage.filesattribute gets cloned, and not lost as of now in Poetry 1.1.8.