Merged
Conversation
Secrus
approved these changes
Aug 22, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
bostonrwalker
pushed a commit
to bostonrwalker/poetry-core
that referenced
this pull request
Aug 29, 2022
* remove unused accepts_prereleases() * remove Dependency.accepts() Co-authored-by: Bartosz Sokorski <b.sokorski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At some point in python-poetry/poetry#6058, it wasn't clear to me whether I should be writing
dependency.accepts(package)orpackage.satisfies(dependency).It turns out that there are no callers of
Dependency.accepts(), so I chosePackage.satisfies().So as to save future developers the confusion, let's remove
Dependency.accepts().Then in passing I noticed
VcsDependency.accepts_prereleases()which is also unused. That smells like it was a confusion at some point withallows_prereleases(), which is a method implemented on theDependency. Let's remove that too.