Skip to content

list .venv when it exists #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sdispater merged 5 commits into from
Feb 28, 2020
Merged

list .venv when it exists #1762

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd351f6
list .venv when it exists
Dec 18, 2019
bf1b849
only list when in-project is true
Dec 18, 2019
9f447c5
missing config
Dec 19, 2019
8397ed2
move logic to manager.list
Dec 30, 2019
5e6e0e6
Add .venv when it exists
Dec 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
list .venv when it exists
  • Loading branch information
frostming committed Dec 30, 2019
commit dd351f6b49c5f985b45c0b3ca558aad778598f0b
5 changes: 4 additions & 1 deletion poetry/console/commands/env/list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,11 @@ def handle(self):

manager = EnvManager(self.poetry)
current_env = manager.get()
env_list = manager.list()
if current_env not in env_list:
env_list.insert(0, current_env)

for venv in manager.list():
for venv in env_list:
name = venv.path.name
if self.option("full-path"):
name = str(venv.path)
Expand Down
16 changes: 16 additions & 0 deletions tests/console/commands/env/test_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import os

import tomlkit

from cleo.testers import CommandTester
Expand Down Expand Up @@ -56,3 +58,17 @@ def test_activated(app, tmp_dir):
)

assert expected == tester.io.fetch_output()


def test_in_project_venv(app, tmpdir):
os.environ.pop("VIRTUAL_ENV", None)

(app.poetry.file.parent / ".venv").mkdir(exist_ok=True)

command = app.find("env list")
tester = CommandTester(command)
tester.execute()

expected = ".venv (Activated)\n"

assert expected == tester.io.fetch_output()