Skip to content

Add missing as_posix() calls #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abn merged 2 commits into from
Jun 28, 2020
Merged

Add missing as_posix() calls #2582

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df83517
Add missing as_posix() calls
msakai Jun 19, 2020
a1345c9
Avoid using os.path.join
msakai Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add missing as_posix() calls 
As PR #2398 changed package.root_dir from str to Path, we need to call
as_posix() to convert it to str before passing to os.path.join.
  • Loading branch information
@msakai
msakai committed Jun 19, 2020
commit df83517afbaa69680f72f2a7e6c0ab415b046425
4 changes: 2 additions & 2 deletions poetry/installation/pip_installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def requirement(self, package, formatted=False):

if package.source_type in ["file", "directory"]:
if package.root_dir:
req = os.path.join(package.root_dir, package.source_url)
req = os.path.join(package.root_dir.as_posix(), package.source_url)
else:
req = os.path.realpath(package.source_url)

Expand Down Expand Up @@ -184,7 +184,7 @@ def install_directory(self, package):
from poetry.utils.toml_file import TomlFile

if package.root_dir:
req = os.path.join(package.root_dir, package.source_url)
req = os.path.join(package.root_dir.as_posix(), package.source_url)
else:
req = os.path.realpath(package.source_url)

Expand Down