Skip to content

Conversation

@ashangit
Copy link

Pull Request Check List

Resolves: #5122 and #4704

  • Added tests for changed code.
  • Updated documentation for changed code.

@tgolsson
Copy link
Contributor

tgolsson commented Apr 21, 2022

I investigated this a while back and suggested #5442 as an alternative fix for at least some of these cases; keeping backwards compatibility which this fix doesn't. #4704 is semi-fixed in 1.20b1 at least and doesn't crash; and my fix is better for that (for PEP503 repos) since it solves the underlying problem of just throwing random requests at webservers.

Also, your version is more complicated than it needs to be, you can look at the secondary index inside the pool to figure out when to break -- this makes the PR much smaller and uses info that Poetry already has 🎉

If you scroll back to April 12th on Discord you can see the discussion @abn and I had and some of the solutions we debunked. :P

@abn
Copy link
Member

abn commented May 15, 2022

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

repository.secondary=true + dependency.source broken?

3 participants