-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add tests for pyproject with multiple readme files #6678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for pyproject with multiple readme files #6678
Conversation
|
Question to maintainers, does poetry have any integration test for |
|
Probably not. (It should be located at Since the test in this PR is passing even without the poetry-core fix, I assume an integration test is required to provoke the issue? |
|
@radoering Exactly, that's why I was looking for an integration test for I will create a new test module then. |
|
Just added a test to verify NOTE: the pipeline is going to fail until python-poetry/poetry-core#486 is merged. |
|
Hi @radoering, after you merged python-poetry/poetry-core#486, I expected the tests to not fail (I just rebased after I expected the pipeline to use latest poetry-core version. Does that happen? |
|
No, it just uses the locked version of poetry-core (no magic). Normally, we just update the locked version after a core release. |
No magic 🙁 In that case, it would be advisable to reopen issue #6633 to signalize users, IMHO. |
|
@Secrus the tests here are going to fail while next poetry-core isn't released. |
|
@radoering when you have a chance, please check this. Now that poetry-core 1.5.0 is locked, the tests are passing. |
radoering
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nitpicks.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
tests/masonry/builders/test_editable_builder.py
tests/console/commands/test_build.py (new file)
Closes: #6633
Depends on: python-poetry/poetry-core#551