tests: ensure forward compatibility with python-poetry/poetry-core#402 #7852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
radoering
force-pushed
the
pypa-packaging-compliance
branch
from
24fe4c2 to
6e3295c
Compare
radoering
force-pushed
the
pypa-packaging-compliance
branch
from
6e3295c to
14b7b8d
Compare
Secrus
reviewed
May 6, 2023
Member
Secrus
left a comment
Secrus
left a comment
There was a problem hiding this comment.
LGTM, just one question and one nitpick
radoering
force-pushed
the
pypa-packaging-compliance
branch
from
32931ac to
7f40cca
Compare
Secrus
approved these changes
May 8, 2023
radoering
force-pushed
the
pypa-packaging-compliance
branch
from
7f40cca to
114632d
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With python-poetry/poetry-core#402 the constraint
">= 2.8.1, == 2.8.*"is parsed to">=2.8.1,<2.9.dev0"instead of">=2.8.1,<2.9.0".All three are equivalent according to PEP 440.
I added some more options (considering zero padding) to make the test more robust to possible future changes.