Skip to content

GH-84783: Make the slice object hashable #101264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 19, 2023
Merged

GH-84783: Make the slice object hashable #101264

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
61c8048
fix the typo in the tuplehash func's comment
furkanonder Jan 23, 2023
ef22a92
make hashable the slice
furkanonder Jan 23, 2023
12c2488
Merge branch 'main' into issue-84783
furkanonder Jan 23, 2023
6dd9926
Merge branch 'main' into issue-84783
furkanonder Jan 25, 2023
886bfff
fix failed slice's test cases
furkanonder Feb 11, 2023
2971147
Merge branch 'main' into issue-84783
furkanonder Feb 11, 2023
093bf38
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 11, 2023
159f3f2
Add version changed to slice's doc
furkanonder Feb 11, 2023
0c78cfc
Update test_doctest.py
OTheDev Feb 12, 2023
cff08dd
Update Doc/library/functions.rst
furkanonder Feb 12, 2023
ea55931
Merge branch 'main' into issue-84783
furkanonder Feb 12, 2023
f0302bf
Update version changed to slice's doc
furkanonder Feb 12, 2023
2c76491
Merge pull request #1 from OTheDev/patch-1
furkanonder Feb 12, 2023
cbd1527
Add more testcases for slice's hash
furkanonder Feb 12, 2023
9f55e46
update testcases for slice's hash
furkanonder Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix failed slice's test cases
  • Loading branch information
@furkanonder
furkanonder committed Feb 11, 2023
commit 886bffff8b3bbe7c7ba47c201d20507f5506907e
7 changes: 1 addition & 6 deletions Lib/test/test_capi/test_misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,11 +415,6 @@ def __setitem__(self, index, value):
with self.assertRaises(TypeError):
_testcapi.sequence_set_slice(None, 1, 3, 'xy')

mapping = {1: 'a', 2: 'b', 3: 'c'}
with self.assertRaises(TypeError):
_testcapi.sequence_set_slice(mapping, 1, 3, 'xy')
self.assertEqual(mapping, {1: 'a', 2: 'b', 3: 'c'})

def test_sequence_del_slice(self):
# Correct case:
data = [1, 2, 3, 4, 5]
Expand Down Expand Up @@ -455,7 +450,7 @@ def __delitem__(self, index):
_testcapi.sequence_del_slice(None, 1, 3)

mapping = {1: 'a', 2: 'b', 3: 'c'}
with self.assertRaises(TypeError):
with self.assertRaises(KeyError):
_testcapi.sequence_del_slice(mapping, 1, 3)
self.assertEqual(mapping, {1: 'a', 2: 'b', 3: 'c'})

Expand Down