Skip to content

gh-104263: Rely on Py_NAN and introduce Py_INFINITY #104202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 10, 2023
Merged

gh-104263: Rely on Py_NAN and introduce Py_INFINITY #104202

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c88a6fb
MAINT: Rely on Py_NAN and Py_HUGE_VAL being correctly defined
seberg May 5, 2023
230882c
MAINT: Introduce and use `Py_INFINIY`; rely on NaN being defined
seberg May 7, 2023
fd39437
TST: Add some tests around (c)math.nan and nan parsing signs
seberg May 7, 2023
1e42249
Change Py_HUGE_VAL to Py_INFINITY where I had missed/forgotten it
seberg May 8, 2023
efd67bc
Add news entry
mdickinson May 8, 2023
e15236d
One more Py_HUGE_VAL -> Py_INFINITY replacement
mdickinson May 8, 2023
18a05cb
And another Py_HUGE_VAL -> Py_INFINITY replacement
mdickinson May 8, 2023
fabf7d3
Add acknowledgement in news entry
mdickinson May 8, 2023
e8c36a2
Fix spelling of Sebastian's name.
mdickinson May 8, 2023
a35ae19
Rely on C99 NAN being defined and ensure NaN sign for creation functions
seberg May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add news entry
  • Loading branch information
@mdickinson
mdickinson committed May 8, 2023
commit efd67bc7bfb194c672190f7d755087f9b3ce3456
6 changes: 6 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2023-05-08-10-34-55.gh-issue-104263.ctHWI8.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Fix ``float("nan")`` to produce a quiet NaN on platforms (like MIPS) where
the meaning of the signalling / quiet bit is inverted from its usual
meaning. Also introduce a new macro ``Py_INFINITY`` matching C99's
``INFINITY``, and refactor internals to rely on C99's ``NAN`` and
``INFINITY`` macros instead of hard-coding bit patterns for infinities and
NaNs.