Skip to content

gh-101819: Explicitly disallow pickle protocols 0 and 1 in _io #104370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

gh-101819: Explicitly disallow pickle protocols 0 and 1 in _io #104370

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e11489e
gh-101819: Explicitly disallow pickle protocols 0 and 1 in _io
erlend-aasland May 10, 2023
5cbffed
Fix indentation (patchcheck)
erlend-aasland May 11, 2023
e3e5442
Mark 'args' as unused
erlend-aasland May 11, 2023
762a616
Pull in main
erlend-aasland May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix indentation (patchcheck)
  • Loading branch information
@erlend-aasland
erlend-aasland committed May 11, 2023
commit 5cbffed7ecf921d02f2d3d6b36bbc2cd576510f8
6 changes: 3 additions & 3 deletions Lib/test/test_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4258,9 +4258,9 @@ def test_pickling(self):
kwargs["encoding"] = "utf-8"
for protocol in range(pickle.HIGHEST_PROTOCOL + 1):
with self.subTest(protocol=protocol, kwargs=kwargs):
with self.open(os_helper.TESTFN, **kwargs) as f:
with self.assertRaisesRegex(TypeError, msg):
pickle.dumps(f, protocol)
with self.open(os_helper.TESTFN, **kwargs) as f:
with self.assertRaisesRegex(TypeError, msg):
pickle.dumps(f, protocol)

@unittest.skipIf(
support.is_emscripten, "fstat() of a pipe fd is not supported"
Expand Down