Skip to content

gh-104389: Add 'unused' keyword to Argument Clinic C converters #104390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 12, 2023
Merged

gh-104389: Add 'unused' keyword to Argument Clinic C converters #104390

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2def279
gh-104389: Argument Clinic now wraps unused args with Py_UNUSED
erlend-aasland May 11, 2023
90c6644
Add NEWS entry
erlend-aasland May 11, 2023
d0f2b5a
Fix docs
erlend-aasland May 11, 2023
b03874b
Revert _io example
erlend-aasland May 11, 2023
bd4b10a
Add test
erlend-aasland May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert _io example
  • Loading branch information
@erlend-aasland
erlend-aasland committed May 11, 2023
commit b03874be14ce4cb7b8a28f442280841535480d64
25 changes: 9 additions & 16 deletions Modules/_io/clinic/textio.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions Modules/_io/textio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ _io__TextIOBase_detach_impl(PyObject *self, PyTypeObject *cls)
/*[clinic input]
_io._TextIOBase.read
cls: defining_class
size: int(unused=True) = -1
/
*args: object

Read at most size characters from stream.

Expand All @@ -79,9 +79,8 @@ If size is negative or omitted, read until EOF.
[clinic start generated code]*/

static PyObject *
_io__TextIOBase_read_impl(PyObject *self, PyTypeObject *cls,
int Py_UNUSED(size))
/*[clinic end generated code: output=51a5178a309ce647 input=f5e37720f9fc563f]*/
_io__TextIOBase_read_impl(PyObject *self, PyTypeObject *cls, PyObject *args)
/*[clinic end generated code: output=3adf28998831f461 input=cee1e84664a20de0]*/
{
_PyIO_State *state = IO_STATE();
return _unsupported(state, "read");
Expand Down