Skip to content

gh-104050: Add typing to Argument Clinic converters #104547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 16, 2023
Merged

gh-104050: Add typing to Argument Clinic converters #104547

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cce842a
gh-104050: Add typing to Argument Clinic converters
erlend-aasland May 16, 2023
8191183
Update Tools/clinic/clinic.py
erlend-aasland May 16, 2023
dd1c773
Also add types to 'default_type'
erlend-aasland May 16, 2023
bdc130d
Remove annotations of simple assignments
erlend-aasland May 16, 2023
75cb81e
Merge branch 'main' into typed-clinic/converters
AlexWaygood May 16, 2023
2e5b92c
Address reviews
erlend-aasland May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Tools/clinic/clinic.py
  • Loading branch information
@erlend-aasland
erlend-aasland authored May 16, 2023
commit 81911831e8cd7679e11e63912e285108a64953a6
3 changes: 2 additions & 1 deletion Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2938,7 +2938,8 @@ def parser_name(self):
}


ConverterDict = dict[str, CConverter]
ConverterType = Callable[..., CConverter]
ConverterDict = dict[str, ConverterType]

# maps strings to callables.
# these callables must be of the form:
Expand Down