Skip to content

gh-104504: Run mypy on cases_generator in CI (and blacken the code) #108090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 18, 2023
Merged

gh-104504: Run mypy on cases_generator in CI (and blacken the code) #108090

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6f4ab6e
gh-104504: Run mypy on cases_generator
corona10 Aug 17, 2023
c0fb645
Add mypy.ini
corona10 Aug 17, 2023
840dab9
Address code review
corona10 Aug 18, 2023
6c89a68
Update
corona10 Aug 18, 2023
42ed502
Move lint
corona10 Aug 18, 2023
6bc0d26
Use alphabetical order
corona10 Aug 18, 2023
999ba10
Update
corona10 Aug 18, 2023
5078f7a
revert
corona10 Aug 18, 2023
e695d2f
Address code review
corona10 Aug 18, 2023
a136c24
Resolve redundant-expr
corona10 Aug 18, 2023
d26b39e
Use matrix
corona10 Aug 18, 2023
c0ae7c2
update
corona10 Aug 18, 2023
dcb3ada
Address code review
corona10 Aug 18, 2023
7f9e68b
Fix indent
corona10 Aug 18, 2023
9b13d6b
run black
corona10 Aug 18, 2023
5b3732d
Use shorter name of Iterator
corona10 Aug 18, 2023
aebfff3
Apply suggestions from code review
corona10 Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use matrix
  • Loading branch information
@corona10
corona10 committed Aug 18, 2023
commit d26b39eff75ed6101c0b661af41a4f7551c1799d
23 changes: 6 additions & 17 deletions .github/workflows/mypy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,11 @@ concurrency:
cancel-in-progress: true

jobs:
mypy-cases-generator:
name: Run mypy on Tools/cases_generator/
mypy:
strategy:
matrix:
target: ["Tools/cases_generator", "Tools/clinic"]
name: Run mypy on ${{ matrix.target }}
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
Expand All @@ -37,18 +40,4 @@ jobs:
cache: pip
cache-dependency-path: Tools/requirements-dev.txt
- run: pip install -r Tools/requirements-dev.txt
- run: mypy --config-file Tools/cases_generator/mypy.ini

mypy-clinic:
name: Run mypy on Tools/clinic/
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: "3.11"
cache: pip
cache-dependency-path: Tools/requirements-dev.txt
- run: pip install -r Tools/requirements-dev.txt
- run: mypy --config-file Tools/clinic/mypy.ini
- run: mypy --config-file ${{ matrix.target }}/mypy.ini