bpo-44686 replace unittest.mock._importer with pkgutil.resolve_name #18544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18544 +/- ##
==========================================
- Coverage 83.25% 83.20% -0.06%
==========================================
Files 1571 1571
Lines 414749 414735 -14
Branches 44456 44453 -3
==========================================
- Hits 345300 345068 -232
- Misses 59795 60019 +224
+ Partials 9654 9648 -6
Continue to review full report at Codecov.
|
Member
|
I think this deserves a discussion and a bpo. @cjw296 this uses |
FFY00
reviewed
May 20, 2020
| (target,)) | ||
| getter = lambda: _importer(target) | ||
| return getter, attribute | ||
| return partial(pkgutil.resolve_name, target), attribute |
Member
There was a problem hiding this comment.
Is there any reason here to be using functools.partial over lambda?
Contributor
Author
There was a problem hiding this comment.
for consistency. lambda: is used twice in this file whereas partial( is used six times
Contributor
|
@tirkarthi: Looking at the diff, we could probably just skip backporting this one... |
graingert
changed the title
Contributor
Author
I've now created the bpo |
cjw296
approved these changes
Jul 21, 2021
cjw296
reviewed
Jul 21, 2021
Misc/NEWS.d/next/Library/2021-07-20-19-35-49.bpo-44686.ucCGhu.rst
Outdated
Show resolved
Hide resolved
Contributor
|
@graingert: Status check is done, and it's a success ❌ . |
Contributor
|
@graingert: Status check is done, and it's a success ✅ . |
Contributor
|
Sorry, I can't merge this PR. Reason: |
Contributor
|
@graingert: Status check is done, and it's a success ✅ . |
d-fence
added a commit
to odoo-dev/odoo
that referenced
this pull request
Feb 10, 2023
Since python/cpython#18544, unittest mock is not able to properly find the "odoo.tools.config". When trying to patch the `options` dictionnary, it leads to `AttributeError: module 'odoo.tools.config' has no attribute 'options'` In order to have the tests working in python <= 3.11, we have to import the config module and patch the options in place.
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Feb 10, 2023
Since python/cpython#18544, unittest mock is not able to properly find the "odoo.tools.config". When trying to patch the `options` dictionnary, it leads to `AttributeError: module 'odoo.tools.config' has no attribute 'options'` In order to have the tests working in python <= 3.11, we have to import the config module and patch the options in place. Part-of: #112317
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Feb 10, 2023
Since python/cpython#18544, unittest mock is not able to properly find the "odoo.tools.config". When trying to patch the `options` dictionnary, it leads to `AttributeError: module 'odoo.tools.config' has no attribute 'options'` In order to have the tests working in python <= 3.11, we have to import the config module and patch the options in place. X-original-commit: 482cb08
d-fence
added a commit
to odoo-dev/odoo
that referenced
this pull request
Feb 13, 2023
Since python/cpython#18544, unittest mock is not able to properly find the "odoo.tools.config". When trying to patch the `options` dictionnary, it leads to `AttributeError: module 'odoo.tools.config' has no attribute 'options'` In order to have the tests working in python <= 3.11, we have to import the config module and patch the options in place.
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Feb 13, 2023
Since python/cpython#18544, unittest mock is not able to properly find the "odoo.tools.config". When trying to patch the `options` dictionnary, it leads to `AttributeError: module 'odoo.tools.config' has no attribute 'options'` In order to have the tests working in python <= 3.11, we have to import the config module and patch the options in place. X-original-commit: 482cb08 Part-of: #112440
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Feb 14, 2023
Since python/cpython#18544, unittest mock is not able to properly find the "odoo.tools.config". When trying to patch the `options` dictionnary, it leads to `AttributeError: module 'odoo.tools.config' has no attribute 'options'` In order to have the tests working in python <= 3.11, we have to import the config module and patch the options in place. Part-of: #112450
StevenSermeus
pushed a commit
to acsone/odoo
that referenced
this pull request
Mar 9, 2023
Since python/cpython#18544, unittest mock is not able to properly find the "odoo.tools.config". When trying to patch the `options` dictionnary, it leads to `AttributeError: module 'odoo.tools.config' has no attribute 'options'` In order to have the tests working in python <= 3.11, we have to import the config module and patch the options in place. Part-of: odoo#112317
This was referenced Jul 24, 2023
Xavier-Do
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 13, 2024
Since python/cpython#18544, unittest mock is not able to properly find the "odoo.tools.config". When trying to patch the `options` dictionnary, it leads to `AttributeError: module 'odoo.tools.config' has no attribute 'options'` In order to have the tests working in python <= 3.11, we have to import the config module and patch the options in place.
Xavier-Do
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 28, 2024
Since python/cpython#18544, unittest mock is not able to properly find the "odoo.tools.config". When trying to patch the `options` dictionnary, it leads to `AttributeError: module 'odoo.tools.config' has no attribute 'options'` In order to have the tests working in python <= 3.11, we have to import the config module and patch the options in place.
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Mar 29, 2024
Since python/cpython#18544, unittest mock is not able to properly find the "odoo.tools.config". When trying to patch the `options` dictionnary, it leads to `AttributeError: module 'odoo.tools.config' has no attribute 'options'` In order to have the tests working in python <= 3.11, we have to import the config module and patch the options in place. Part-of: #151989
J08nY
added a commit
to crocs-muni/sec-certs
that referenced
this pull request
Oct 17, 2025
Damn, python/cpython#18544 actually changed the behavior.
|
Hi all, sorry to resurrect a very old PR. However, this change actually changed the behavior of the lookup used in the mockers. A clear example is given here: scikit-hep/pyhf#2143 (comment). I wonder if the Python docs for unittest could be changed to include information about the changed behavior. However, I am not sure how to describe the actual changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue44686
Automerge-Triggered-By: GH:cjw296