Skip to content

GH-92184: Convert os.altsep to '/' in filenames when creating ZipInfo objects #92185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2023
Merged

GH-92184: Convert os.altsep to '/' in filenames when creating ZipInfo objects #92185

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0fa220
Convert os.altsep to '/' in filenames when creating ZipInfo objects
pR0Ps May 2, 2022
43da828
reword & ReSTify the news entry.
gpshead May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Convert os.altsep to '/' in filenames when creating ZipInfo objects 
This causes the zipfile module to also consider the character defined by
`os.altsep` (if there is one) to be a path separator and convert it to a
forward slash, as defined by the zip specification.
  • Loading branch information
@pR0Ps
pR0Ps committed Apr 24, 2023
commit c0fa220c936cff6e49ca767cb702d9169560d317
2 changes: 2 additions & 0 deletions Lib/zipfile/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,8 @@ def _sanitize_filename(filename):
# ZIP format specification.
if os.sep != "/" and os.sep in filename:
filename = filename.replace(os.sep, "/")
if os.altsep and os.altsep != "/" and os.altsep in filename:
filename = filename.replace(os.altsep, "/")
return filename


Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2022-05-02-16-21-05.gh-issue-92184.hneGVW.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
When creating zip files using the ``zipfile`` module, ``os.altsep`` will always
be treated as a path separator. Patch by Carey Metcalfe.