Skip to content

gh-95011: Migrate syslog module to Argument Clinic #95012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Oct 8, 2022
Merged

gh-95011: Migrate syslog module to Argument Clinic #95012

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
6e2cc36
Migrated syslog module to Argument Clinic
noamcohen97 Jul 19, 2022
565d4b9
reformat syslog functions doc
noamcohen97 Jul 20, 2022
8626c65
change syslog audit args formatting
noamcohen97 Jul 20, 2022
0585b4d
Merge branch 'main' into clinic-syslog
Jul 25, 2022
a2844f0
Update Modules/syslogmodule.c
noamcohen97 Jul 26, 2022
9b853db
Update Modules/syslogmodule.c
noamcohen97 Jul 26, 2022
30db659
syslog: better test coverage
noamcohen97 Jul 26, 2022
dde4e7c
syslog: fix ref leak
noamcohen97 Jul 26, 2022
a90f93d
fix whitespace issues
noamcohen97 Jul 26, 2022
54d4f04
Merge remote-tracking branch 'upstream/main' into clinic-syslog
noamcohen97 Jul 26, 2022
1aa615d
Merge branch 'main' into clinic-syslog
noamcohen97 Jul 26, 2022
895a492
use `support.import_helper.import_module`
noamcohen97 Jul 26, 2022
3d29577
syslog: pep 7
noamcohen97 Jul 26, 2022
29680c9
use the str converter
noamcohen97 Jul 27, 2022
149e646
Merge remote-tracking branch 'upstream/main' into clinic-syslog
noamcohen97 Aug 17, 2022
430d12c
regen clinic
noamcohen97 Aug 17, 2022
fd6e589
regen global strings
noamcohen97 Aug 17, 2022
0e0d9c6
Merge branch 'main' into clinic-syslog
noamcohen97 Sep 7, 2022
f28b332
Merge remote-tracking branch 'upstream/main' into clinic-syslog
noamcohen97 Oct 7, 2022
7a812bc
Merge branch 'main' into clinic-syslog
noamcohen97 Oct 7, 2022
8903e8b
remove backported tests
noamcohen97 Oct 8, 2022
e09825c
Delete 2022-07-19-16-32-52.gh-issue-95011.P5t6l9.rst
serhiy-storchaka Oct 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use the str converter
  • Loading branch information
@noamcohen97
noamcohen97 committed Jul 27, 2022
commit 29680c9dc6a0b034ef642a86d8c0ddfe0db93c68
2 changes: 1 addition & 1 deletion Lib/test/test_audit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ def test_sys_getframe(self):
self.assertEqual(actual, expected)

def test_syslog(self):
syslog = import_helper.import_module("syslog")
syslog = import_helper.import_module("syslog")

returncode, events, stderr = self.run_python("test_syslog")
if returncode:
Expand Down
12 changes: 6 additions & 6 deletions Modules/clinic/syslogmodule.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 3 additions & 9 deletions Modules/syslogmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ syslog.syslog
priority: int(c_default="LOG_INFO") = LOG_INFO
]

message as message_object: unicode
message: str

/

Expand All @@ -186,15 +186,9 @@ Send the string message to the system logger.

static PyObject *
syslog_syslog_impl(PyObject *module, int group_left_1, int priority,
PyObject *message_object)
/*[clinic end generated code: output=3361dc7f2e863377 input=02500dddce0095df]*/
const char *message)
/*[clinic end generated code: output=c3dbc73445a0e078 input=ac83d92b12ea3d4e]*/
{
const char *message;

message = PyUnicode_AsUTF8(message_object);
if (message == NULL)
return NULL;

if (PySys_Audit("syslog.syslog", "is", priority, message) < 0) {
return NULL;
}
Expand Down