[tkinter] Annotate several functions #14631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Akuli
reviewed
Aug 24, 2025
This comment has been minimized.
This comment has been minimized.
|
With the removal of all the type aliases, this PR has become quite large. Could you make separate pull requests of removing all the type aliases? This way, if removing some type alias causes a problem for someone, we can simply revert one removal PR instead of trying to revert parts of a big PR. It would also be easier to review. |
This reverts commit 63b2171.
This comment has been minimized.
This comment has been minimized.
donBarbos
changed the title
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
donBarbos
added a commit
to donBarbos/typeshed
that referenced
this pull request
Sep 18, 2025
Inspired by python#14631 (comment) I only got rid of some of the aliases (the simplest ones) to make sure that others supported this action and to test the functionality of this idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading documentation about Tk data types, I noticed that the value
fillis listed as allowed forjustifytype, whereas the Tcl manpage does not mention it. I might be missing something, but it seems like this value should apply to thejustifyargument. Could this be a documentation error, or have I misunderstood something?